Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rd3ic-003cG1-P4 for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Feb 2024 07:42:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rd3ia-0090Ts-Tn for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Feb 2024 07:42:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rd3iZ-0090Tk-QC for pgsql-hackers@lists.postgresql.org; Thu, 22 Feb 2024 07:42:09 +0000 Received: from mail.clear-code.com ([153.126.206.245]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rd3iR-000IhD-JY for pgsql-hackers@postgresql.org; Thu, 22 Feb 2024 07:42:07 +0000 Received: from localhost (unknown [IPv6:2404:7a80:89c1:1200:6af9:2266:1443:f149]) by mail.clear-code.com (Postfix) with ESMTPSA id 7AC4C186761 for ; Thu, 22 Feb 2024 16:41:50 +0900 (JST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.clear-code.com 7AC4C186761 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=clear-code.com; s=default; t=1708587710; bh=YySGh1uYGo+8mrWc2wQlWNkRTLxLhGeCgMS7Xo3xpBI=; h=Date:To:Subject:From:In-Reply-To:References:From; b=t7BYH5sW6tyCA0O96bWoJ0EfMRhRlpTvcHDaL1B1fjWoMq7ZPHp3iyYYuLcj8Ll4G jfFuAdw7ypj9swAoDjglZY9dJlRWOjGRw7w9mJnFwhFjRCpTBQ6397OS75sMp+TLcg 4OCWkvOmvGMjohrO6Hh/P0iS/c1k2gglhyxdfM38= Date: Thu, 22 Feb 2024 16:41:48 +0900 (JST) Message-Id: <20240222.164148.1096963224859199636.kou@clear-code.com> To: pgsql-hackers@postgresql.org Subject: Re: meson: Specify -Wformat as a common warning flag for extensions From: Sutou Kouhei In-Reply-To: <20240122.141139.931086145628347157.kou@clear-code.com> References: <20240122.141139.931086145628347157.kou@clear-code.com> X-Mailer: Mew version 6.8 on Emacs 29.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Rspamd-Server: mail.clear-code.com X-Rspamd-Queue-Id: 7AC4C186761 X-Rspamd-Action: no action X-Spamd-Result: default: False [1.40 / 999.00]; MID_CONTAINS_FROM(1.00)[]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_ZERO(0.00)[0]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; ASN(0.00)[asn:2518, ipnet:2404:7a80::/29, country:JP]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[postgresql.org:url,localhost:helo]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; SURBL_MULTI_FAIL(0.00)[localhost:server fail,postgresql.org:server fail] List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, Could someone take a look at this? Patch is attached in the original e-mail: https://www.postgresql.org/message-id/20240122.141139.931086145628347157.kou%40clear-code.com Thanks, -- kou In <20240122.141139.931086145628347157.kou@clear-code.com> "meson: Specify -Wformat as a common warning flag for extensions" on Mon, 22 Jan 2024 14:11:39 +0900 (JST), Sutou Kouhei wrote: > Hi, > > I'm an extension developer. If I use PostgreSQL built with > Meson, I get the following warning: > > cc1: warning: '-Wformat-security' ignored without '-Wformat' [-Wformat-security] > > Because "pg_config --cflags" includes -Wformat-security but > doesn't include -Wformat. > > Can we specify -Wformat as a common warning flag too? If we > do it, "pg_config --cflags" includes both of > -Wformat-security and -Wformat. So I don't get the warning. > > > Thanks, > -- > kou