Feedback-ID: ia2694551:Fastmail
Date: Thu, 22 Feb 2024 17:04:57 +0100
From: 'Alvaro Herrera' <alvherre@alvh.no-ip.org>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: 'Euler Taveira' <euler@eulerto.com>, 
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>, vignesh C <vignesh21@gmail.com>, 
	Michael Paquier <michael@paquier.xyz>, Peter Eisentraut <peter@eisentraut.org>, 
	Andres Freund <andres@anarazel.de>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, 
	Amit Kapila <amit.kapila16@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, 
	=?utf-8?B?RmFicsOtemlv?= de Royes Mello <fabriziomello@gmail.com>
Subject: Re: speed up a logical replica setup
Message-ID: <202402221604.pfd722wbw3tx@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <TYCPR01MB12077E9F3EC59D2B112D289A4F5562@TYCPR01MB12077.jpnprd01.prod.outlook.com>
Archived-At: <https://www.postgresql.org/message-id/202402221604.pfd722wbw3tx%40alvherre.pgsql>
Precedence: bulk

Hello,

On 2024-Feb-22, Hayato Kuroda (Fujitsu) wrote:

> Dear Alvaro,

> > Hmm, but doesn't this mean that the server will log an ugly message
> > that "client closed connection unexpectedly"?  I think it's nicer to
> > close the connection before terminating the process (especially
> > since the code for that is already written).
> 
> OK. So we should disconnect properly even if the process exits. I
> added the function call again. Note that PQclear() was not added
> because it is only related with the application.

Sounds about right, but I didn't verify the patches in detail.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Hay quien adquiere la mala costumbre de ser infeliz" (M. A. Evans)