Date: Mon, 4 Mar 2024 15:50:48 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: bt23nguyent <bt23nguyent@oss.nttdata.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Improve the log message output of basic_archive when
 basic_archive.archive_directory parameter is not set
Message-ID: <20240304215048.GA3367383@nathanxps13>
References: <D3038255-EAB5-4164-A9E3-7967B6738993@yesql.se>
 <18cbd8ca6f5390cda2920644f891a419@oss.nttdata.com>
 <20230925222047.GA3173226@nathanxps13>
 <482056B1-D930-417C-9473-CB1A045E42AE@yesql.se>
 <20231013022559.GA1266364@nathanxps13>
 <E863EDCA-EFEA-4DFA-9E93-024D464DE260@yesql.se>
 <20240105230357.GA2425960@nathanxps13>
 <AB31C950-5BA6-49F2-ADF9-F8E8334EB4A2@yesql.se>
 <20240304172252.GA3161951@nathanxps13>
 <1DFBEAE6-01A6-49E8-8360-BA9113E33092@yesql.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1DFBEAE6-01A6-49E8-8360-BA9113E33092@yesql.se>
Archived-At: 
 <https://www.postgresql.org/message-id/20240304215048.GA3367383%40nathanxps13>
Precedence: bulk

On Mon, Mar 04, 2024 at 09:27:23PM +0100, Daniel Gustafsson wrote:
> Looks good from a read-through, I like it.  A few comments on the commit
> message only:
> 
> actionable details about the source of the miconfiguration.  This
> s/miconfiguration/misconfiguration/

I reworded the commit message a bit to avoid the word "misconfiguration,"
as it felt a bit misleading to me.  In any case, this was fixed, albeit
indirectly.

> Reviewed-by: Daniel Gustafsson, ︼varo Herrera
> Alvaro's name seems wrong.

Hm.  It looks alright to me.  I copied the name from his e-mail signature,
which has an accent over the first 'A'.  I assume that's why it's not
showing up correctly in some places.

Anyway, I've committed this now.  Thanks for taking a look!

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com