Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhSoP-00Bafz-Pn for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Mar 2024 11:18:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rhSoO-00G0gQ-7a for pgsql-hackers@arkaria.postgresql.org; Tue, 05 Mar 2024 11:18:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhSoM-00G0f3-Mu for pgsql-hackers@lists.postgresql.org; Tue, 05 Mar 2024 11:18:20 +0000 Received: from fhigh5-smtp.messagingengine.com ([103.168.172.156]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhSoC-002xSG-L9 for pgsql-hackers@lists.postgresql.org; Tue, 05 Mar 2024 11:18:17 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 292DD1140191; Tue, 5 Mar 2024 06:18:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 05 Mar 2024 06:18:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1709637488; x= 1709723888; bh=Q7kD+r9pXd193/m3Ns/a/kqI/7mZtmzGNOpycrokegM=; b=j L7ovK3i2dPaBsfuEjJWXns5UrShK4+U5edGaOc1Uf/b89HtpVm87LcFKrh/OG66/ XlHiCyCshhXS9rILhtgHl64lS259TUt4Bpvvwb54wgGPgT/UE1h0U21mUO8ltZ/k ICURTcM3Frh4iGVL89UCzjBJUpf+MgxE4whIunXdGkipnorfLKVWh+x+eRpm2h0c qddG7tA3Z9BkXCxtt4k3cgVRbonnbVw+Ftg+rNpvXxXI7vQNz9zZJOZ/ZkNEP5Ov UCdAs5VhRz+195VrSfYGNzWQHf0xtpw4jgzXpB0UqVOPqfjzuXBoMPCrnnexcO9h RYczjx84J+bFhJpcV+IpA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrheelgddvfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkgggtugfgjgesthekre dttddtjeenucfhrhhomheptehlvhgrrhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgv segrlhhvhhdrnhhoqdhiphdrohhrgheqnecuggftrfgrthhtvghrnhepvdektdffudfftd ffffehfffhjeejhffgieeuueekjeekfffgudffhfduffffueevnecuffhomhgrihhnpegv nhhtvghrphhrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Mar 2024 06:18:07 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1709637485; bh=bRKo93jxmeCoMi1jvNHkFaxE6TrE/Opg4rVXW9/AhjE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Vuc0kFJ6t74oekNN/n+Dzo2R1UBzrILUBO7CCGS19yOjJLfXs+7QiDvogvPC6OQqb 273ZiY5gzkm9vRZ6QTpLfSDrmrZkvnrwZZTRZcfy/3Jte+01qgb49ke44X1gczdKn8 FaGezrLWxNA2TOuCMZCoIF0f1b1ur5f49LxYs3zd0onnQ8OuzxxZIGkr1vZ4lAKdR4 61Pw61U7LgcEwo97c+IGa8CHaqxK3V2c73ygvTRcDGldsgB0Ces16i5055lduTbP3a QB0A1rWUPrX4QLvAgthyr2e+ZgPvopulZ0aGH3khPuvNpYgqeRIC4MnNDSRN7YzTgi 6xy7R6kaLgAGA== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id 50986CD5; Tue, 5 Mar 2024 12:18:05 +0100 (CET) Date: Tue, 5 Mar 2024 12:18:05 +0100 From: Alvaro Herrera To: Tom Lane Cc: Kyotaro Horiguchi , x4mmm@yandex-team.ru, dilipbalaut@gmail.com, tndrwang@gmail.com, pgsql-hackers@lists.postgresql.org, tomas.vondra@enterprisedb.com Subject: Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock Message-ID: <202403051118.s6qxtmdj56a5@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3898618.1709592118@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-Mar-04, Tom Lane wrote: > In hopes of noticing whether there are other similar thinkos, > I permuted the order of the SlruPageStatus enum values, and > now I get the expected warnings from gcc: Thanks for checking! I pushed the fixes. Maybe we should assign a nonzero value (= 1) to the first element of enums, to avoid this kind of mistake. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/