Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1riI2E-00GDpo-QF for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Mar 2024 18:00:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1riI2D-007eLv-8V for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Mar 2024 18:00:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1riI2C-007eLn-Vf for pgsql-hackers@lists.postgresql.org; Thu, 07 Mar 2024 18:00:01 +0000 Received: from mail-io1-xd2b.google.com ([2607:f8b0:4864:20::d2b]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1riI29-003Lso-TV for pgsql-hackers@lists.postgresql.org; Thu, 07 Mar 2024 18:00:00 +0000 Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-7c7ee7fa1d8so55270939f.1 for ; Thu, 07 Mar 2024 09:59:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709834398; x=1710439198; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fKRzURn8v0GKSif774DWTJg6uA8Cs5+X03k1g0119pA=; b=Et6RoreCx1zCIdzGGp012r3n2iK/Qvj5OIlzEbtvRRjjq67ESitGgRztzPq9R+hQhn dhTIcJCX7mjIkOUI5A/pSfMXmFhudTMdgjf7cM2p7Gt2Yp3ONVqHYdFpnY3TuLPLOXfW uWgN4hAq/VoH3pQEChYIGCXtZl8+OftEUvElYVfgdpZ7y/aDtCCNrtrbBaLcwx2jrpXX PjPbPjnfXSPidLqEQNyBjBpdW65CZ8AzNASJJG9+fewEyTdabOLmta6sXwNWFkxCtRB+ GUxjn8lEGWpNF8c7iu8ccqe2oygFf8QdfBl7X9XKCy39uU5POoSQNp8Ud10mUih75pGy mmVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709834398; x=1710439198; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fKRzURn8v0GKSif774DWTJg6uA8Cs5+X03k1g0119pA=; b=Hrk7MYupI0qO9f+u4ZeqmbYWuhYKTLR55+xIIK17voQlsub4HLjuPyMbx4f6qZ7y2x mymIVX2d7X/vmNrUIka8PPqvubUUHPsFgQTBmMl4gsF1qpGLGARt/hCGNMfsd3HdtWL8 /QjT1JwFWpyB9wn8I9FCJBgW26tyb3yyggxcNb8620j7wHxzszpmF/QzLeJEUS92QPyJ dOJzLSN9fkYKhlGNLBv8tpkHYrwEBjyQI0Lbv0Nu4267us+AStrtPBuBv8izPhQAUVrb TyP2ZyQQaubRzfUOXwo4jvy73lgABS/EL4QkfDxlMc2Z5+8cPmRcsMcuKg2hTdfaBshy X34Q== X-Forwarded-Encrypted: i=1; AJvYcCUlO0Q5BlEM6l2aIoY8bobyRIJIymy8e2/hfqhEzdIYKu2FHqtzAj1qRkADSEgKYlYjDoTMEcZDUV6QZSP1zw32nkXOx0iVCqSTAyyizoxOs074 X-Gm-Message-State: AOJu0Ywnzmu9A7EBhR0FyvptHa2XNgn56z4xW+g9gjfb/W7dXNnYbwLQ SJ31n3uIkf3RE9vVJCz3eXi2XVqBpt58t4Qo5f3c+7JhPozh5El7 X-Google-Smtp-Source: AGHT+IFDpxb491xQ8/fCZNjtNRVSNPnno3wQVLfRkJDZy0pH7kakaqVl4ZXn30ciJMiJ6jgPTzHSxQ== X-Received: by 2002:a05:6602:8c1:b0:7c8:4208:9b30 with SMTP id h1-20020a05660208c100b007c842089b30mr16738878ioz.7.1709834397019; Thu, 07 Mar 2024 09:59:57 -0800 (PST) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id k2-20020a02ccc2000000b00476affbce9fsm403460jaq.6.2024.03.07.09.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 09:59:56 -0800 (PST) Date: Thu, 7 Mar 2024 11:59:55 -0600 From: Nathan Bossart To: Alvaro Herrera Cc: "Amonson, Paul D" , Andres Freund , "Shankaran, Akash" , Noah Misch , Tom Lane , Matthias van de Meent , "pgsql-hackers@lists.postgresql.org" Subject: Re: Popcount optimization using AVX512 Message-ID: <20240307175955.GA502899@nathanxps13> References: <202403071753.mirzr4kppbkb@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202403071753.mirzr4kppbkb@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Mar 07, 2024 at 06:53:12PM +0100, Alvaro Herrera wrote: > Really, I don't think this is very important as a review point, because > if the configure.ac file is changed in the patch, it's best for the > committer to run autoconf on their own, using a pristine GNU autoconf; > the configure file in the submitted patch is not relevant, only > configure.ac matters. Agreed. I didn't intend for this to be a major review point, and I apologize for the extra noise. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com