Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1riMf5-00Gnhq-Aq for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Mar 2024 22:56:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1riMf1-008tWx-1u for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Mar 2024 22:56:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1riMf0-008tWp-Ov for pgsql-hackers@lists.postgresql.org; Thu, 07 Mar 2024 22:56:23 +0000 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1riMex-003Nmn-9m for pgsql-hackers@postgresql.org; Thu, 07 Mar 2024 22:56:21 +0000 Received: by mail-io1-xd2a.google.com with SMTP id ca18e2360f4ac-7c88c7a9262so25896839f.3 for ; Thu, 07 Mar 2024 14:56:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709852179; x=1710456979; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=31VSiXj+bllUu2un/9oOVF09OzfG2zDBmO/CDsg5wWs=; b=gC46douV6UHCL1ftUGNXSdtqlh3gxe7/d5DODZQBQnZSOB5T8x8iqiGhyWtitdswX/ nicgRd7Unu3NkxBI7n8ZqD8pgvXUwSL0XUpZ48Ajo5LqmisxB0q5WBPSDMMxr32hay/K HG4irBWX9F4a1yVAOR7cCZs4IUxJjp1Q41u7ENvfgT4YjZuLt1spYlgXZ1eM/MX0s16H SeydFqRG4JwYA897bpq0it1QGfCw1zic4g7mBYVzOMZkRj5Vdnchyuu+nvSav2BNUWR2 8iMb5g7kue3mFKn8yuFzVVxwOxBD9nb6Z9y2MLHiXsgArr4uRjWDeyB7brKBuzcg/cVD 2T7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709852179; x=1710456979; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=31VSiXj+bllUu2un/9oOVF09OzfG2zDBmO/CDsg5wWs=; b=kQeFOnv/pgshO/F1raIozu4PoQgxHn6sQMMu0565S2HVnjAIcqaAYvTb2rR/acYZ4Q E8Ll06YPVENBTJsjSEmhB24OsDR4PEnP6cScG4fWrSR+2DeGA9k7BPYc1G4DEAHwCnSB 4ferzhEkMFd6+M88hcujm5wuPyjF7HE606/P0TIo4uBAhxRxygkA8T9ZVKIcMP5eiS6L znHxRKk0TR+ClmIwcPG9ZYqA/OGj3EtjN+jjpzE9cb4x2ZSEAMVJnp3szzvGPvyqBBfu ugyQ0+e30bmvkwR6XJ88gdP7tr0CApJRFfL3tL8+do+fuZETmVhoYNrKqxiPlNeuTKSk +v8w== X-Forwarded-Encrypted: i=1; AJvYcCXzgXoWOpB5MdwdUkpza91pLLmTkTbpT3qCdj4hpmBo0EIz/Rcrp40KdU6rQseqCUJJXW+g9lmzgvV7SM22bayi8cYjTNNNvJOr0qHF X-Gm-Message-State: AOJu0YwQknbVzOtYWbKXfF2LMaPkNkoPXsHHfbYxGNj8KMO72twqHM7F fs9dL5x4c+VQHl+Gp+hSR2Smc5i99/dXbaO/XesZ0DXGphlqn7om X-Google-Smtp-Source: AGHT+IGXTlL9OZMueq9A9D2Nagdml+TbJsFShgcMCuI8/Wy6LHUlhBXhwsCSdobt4641p6fh7q0zkg== X-Received: by 2002:a05:6e02:1747:b0:365:3a69:1e1a with SMTP id y7-20020a056e02174700b003653a691e1amr22570714ill.0.1709852179587; Thu, 07 Mar 2024 14:56:19 -0800 (PST) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id g2-20020a056e020d0200b00362902d6818sm4444714ilj.62.2024.03.07.14.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 14:56:18 -0800 (PST) Date: Thu, 7 Mar 2024 16:56:17 -0600 From: Nathan Bossart To: Yugo NAGATA Cc: jian he , Sergei Kornilov , Nikita Malakhov , pgsql-hackers@postgresql.org Subject: Re: pg_column_toast_chunk_id: a function to get a chunk ID of a TOASTed value Message-ID: <20240307225617.GA615950@nathanxps13> References: <20240126094237.cec181d85e05556533d79914@sraoss.co.jp> <20240130133459.b1748c23998201476f49ca59@sraoss.co.jp> <20240130145632.d6609830bfd5139115f302cf@sraoss.co.jp> <20240201134524.d647b3d185e5252162eb0436@sraoss.co.jp> <20240205162823.6c705517ca6898e482b69b9e@sraoss.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240205162823.6c705517ca6898e482b69b9e@sraoss.co.jp> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Feb 05, 2024 at 04:28:23PM +0900, Yugo NAGATA wrote: > On Thu, 1 Feb 2024 17:59:56 +0800 > jian he wrote: >> v6 patch looks good. > > Thank you for your review and updating the status to RwC! I think this one needs a (pretty trivial) rebase. I spent a few minutes testing it out and looking at the code, and it seems generally reasonable to me. Do you think it's worth adding something like a pg_column_toast_num_chunks() function that returns the number of chunks for the TOASTed value, too? -- Nathan Bossart Amazon Web Services: https://aws.amazon.com