Date: Sat, 9 Mar 2024 08:50:28 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Yugo NAGATA <nagata@sraoss.co.jp>
Cc: jian he <jian.universality@gmail.com>, Sergei Kornilov <sk@zsrv.org>,
	Nikita Malakhov <hukutoc@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: pg_column_toast_chunk_id: a function to get a chunk ID of a
 TOASTed value
Message-ID: <20240309145028.GB1111406@nathanxps13>
References: 
 <CACJufxEmN=CPZt9-ZFLF7fje_-6kv51jV08w8p0e89O1Mg8RfA@mail.gmail.com>
 <20240130145632.d6609830bfd5139115f302cf@sraoss.co.jp>
 <CACJufxGpqVg9j_Fb7aBRwricx1ZTV+vEQfUmwuVpNhrRyvcAdA@mail.gmail.com>
 <20240201134524.d647b3d185e5252162eb0436@sraoss.co.jp>
 <CACJufxHyDKcB+34JUDFJubO7GkLNNjZXxbf9jSnSdqVKS8T9+g@mail.gmail.com>
 <20240205162823.6c705517ca6898e482b69b9e@sraoss.co.jp>
 <20240307225617.GA615950@nathanxps13>
 <20240308153155.4c4b2fee3ed1431203e41016@sraoss.co.jp>
 <20240308221758.GB1060542@nathanxps13>
 <20240309115718.deb9209b7f53883cc8e1b4b3@sraoss.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240309115718.deb9209b7f53883cc8e1b4b3@sraoss.co.jp>
Archived-At: 
 <https://www.postgresql.org/message-id/20240309145028.GB1111406%40nathanxps13>
Precedence: bulk

On Sat, Mar 09, 2024 at 11:57:18AM +0900, Yugo NAGATA wrote:
> On Fri, 8 Mar 2024 16:17:58 -0600
> Nathan Bossart <nathandbossart@gmail.com> wrote:
>> Is this guaranteed to be TOASTed for all possible page sizes?
> 
> Should we use block_size?
> 
>  SHOW block_size \gset
>  INSERT INTO test_chunk_id(v1,v2)
>   VALUES (repeat('x', 1), repeat('x', (:block_size / 4)));
> 
> I think this will work in various page sizes. 

WFM

> +SHOW block_size; \gset
> + block_size 
> +------------
> + 8192
> +(1 row)

I think we need to remove the ';' so that the output of the query is not
saved in the ".out" file.  With that change, this test passes when Postgres
is built with --with-blocksize=32.  However, many other unrelated tests
begin failing, so I guess this fix isn't tremendously important.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com