Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rniAR-00EfA9-7t
	for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Mar 2024 16:54:55 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1rniAP-005WHp-LC
	for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Mar 2024 16:54:54 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1rniAP-005WHh-CA
	for pgsql-hackers@lists.postgresql.org; Fri, 22 Mar 2024 16:54:53 +0000
Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.94.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1rniAM-005stW-1K
	for pgsql-hackers@lists.postgresql.org; Fri, 22 Mar 2024 16:54:52 +0000
Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-7cc133f431fso97498639f.1
        for <pgsql-hackers@lists.postgresql.org>; Fri, 22 Mar 2024 09:54:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1711126490; x=1711731290; darn=lists.postgresql.org;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=ALGzd/bRtX2ZwZ7Q1Qx9vmovG9CTPnK6aIzSMfDjpwg=;
        b=TvK7zaybdPnPhj27k9BdgM8a4XpGqLlfjxQk/LxxT3EHwHXntykKUMeL2eQAnRbM0Z
         GeAhKhQcpAHg7X1hxkY4XWvqqONMfufClWCtyj8pWlSCaflLYmGX0fYqbJZRbCG/rsnh
         8Whw50K6aANFQrHXxjCOqAoTEI2fa26R3wzt7BnpRg79M84ix1VpBa1fOQEMBA0WsCdX
         8748LFIEVEmnDZYwTERMtPWfSj0qsXTWVlxQ4kV7JKfBjMa2YCMoABwd04+xbmCHVzNt
         tA9zpfLPRLlPdX7htuJG+Pq3QQvwnvOq9EkSmEMF40J6zAth4ER8LR7V7CGWmmP4ebzT
         y/jg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1711126490; x=1711731290;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=ALGzd/bRtX2ZwZ7Q1Qx9vmovG9CTPnK6aIzSMfDjpwg=;
        b=NYY0IlVcLhPqSd7p/VfU93TWKx8wucBAQB6L7XBRkaRVqjJATVmq+5CYGWAcEDujm1
         yKV1+qmVG4xYFuB+vYtD+q6LhrYYftsBR3aGKguPhOzGnQG/DFcp833ntrQeCwenLSRP
         /Vp1k5bb2+1yxQpizqxI6aeqkbnFi5nhFyReGtFqjGo6jxOpusf6MkM4ANtJsMlTUc1n
         dROl1m2+AR6Qi7hmOvfErwo9XtLP8FtPlpbJ0LAypQ8YQblFGo9QVrdrrIQzyNeZvW9D
         BnNYMtAEj11qpG0X9Y+pkgPPHsEYuLt9qr2GSLAvIy2LxorWhTdJj6Qb9D3VPb+15ooA
         h/YA==
X-Gm-Message-State: AOJu0Yx0kgJlrkzH8iy83m0PTb3P2io+oEdwLw0k+u++DncdmnNApP1g
	Bw5KP5P7FA0RMilcFKsbZ7EGKruTbpTyfahoFo42SKKMX93S8UIi
X-Google-Smtp-Source: AGHT+IGEeIykJeMHaMq0hjG8Yki38Nqo7w+aao3UDwFZkiz8OgzDFGwxjz34Oktnu0/zdBdpXlRyLQ==
X-Received: by 2002:a5e:8b04:0:b0:7d0:32b6:fbe1 with SMTP id g4-20020a5e8b04000000b007d032b6fbe1mr2176571iok.21.1711126490595;
        Fri, 22 Mar 2024 09:54:50 -0700 (PDT)
Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172])
        by smtp.gmail.com with ESMTPSA id o26-20020a02cc3a000000b00474dad114a6sm607011jap.80.2024.03.22.09.54.50
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 22 Mar 2024 09:54:50 -0700 (PDT)
Date: Fri, 22 Mar 2024 11:54:48 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, alex work <alexwork033@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>
Subject: Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs
Message-ID: <20240322165448.GA2350322@nathanxps13>
References: <619340.1711050134@sss.pgh.pa.us>
 <642442.1711053105@sss.pgh.pa.us>
 <20240321204012.GA1992418@nathanxps13>
 <20240322005139.GA2060816@nathanxps13>
 <806361.1711069194@sss.pgh.pa.us>
 <20240322144739.GA2321246@nathanxps13>
 <20240322145532.GA2346110@nathanxps13>
 <907785.1711121266@sss.pgh.pa.us>
 <20240322163952.GA2347986@nathanxps13>
 <939945.1711126395@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <939945.1711126395@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/20240322165448.GA2350322%40nathanxps13>
Precedence: bulk

On Fri, Mar 22, 2024 at 12:53:15PM -0400, Tom Lane wrote:
> Would you like to review the catcache patch further, or do you
> think it's good to go?

I'll take another look this afternoon.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com