Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rolc8-003Fi0-9W for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Mar 2024 14:47:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rolc6-004N4J-RY for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Mar 2024 14:47:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rolc6-004N4B-FO for pgsql-hackers@lists.postgresql.org; Mon, 25 Mar 2024 14:47:51 +0000 Received: from mail-io1-xd33.google.com ([2607:f8b0:4864:20::d33]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rolc1-006Lef-J5 for pgsql-hackers@lists.postgresql.org; Mon, 25 Mar 2024 14:47:49 +0000 Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-7cc0e0dba0fso179207139f.3 for ; Mon, 25 Mar 2024 07:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711378066; x=1711982866; darn=lists.postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6hIVhkJjOUrUD0KGqbkuHAXWlAvXi6DSU8Psr6fFFkQ=; b=BT6jxy4ZhWQqZXMXJaCvgA+Ga3vPMUkIAbe/TsB3JPuFVIo+LGOKe/nZy80GKE+jOO ZbjdWDhBLbtQQ//I3s0oVWyd9T9S67v/FHQy/Vxmaw5oMihjqWQanOpGoM0u8CfFNHGI IZ+kaIyOvXz4+Is6fVwTM/6+JcnFNuMhycWOy3NgdC/JCZfUKQfIPmKYPCiwIcuBKmUc yzlQznnshkfj/VzfddGnuWC9HhWTr01qvD2iEOhYxUqkF4XOgWIaAo+Jo7HZkP1ONfOV UCRSXlukAwr2Qd6rqHhLVrbIULlCp+KCUSyTl6a/nijIlSWNaam2vgzHP18f5U+0BGnu l1xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711378066; x=1711982866; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6hIVhkJjOUrUD0KGqbkuHAXWlAvXi6DSU8Psr6fFFkQ=; b=EJkhKcn7+q8ZApGIuaKzqnCxT98KsJiR7je5JvtVnLNJTtqCCOzkGrO+9MhalinBY0 QDPU3OLXktsmjuca0MfiZKE2TVQOKv9XKjrhKSDM3cq2/dAfI/bbR79QktR5g9+r2D1g bEBaqxOoS1kH0BAsHirTQG7OJLOWqMwtCiyvFPKYb1BAaW+qQKq0AENly1YSUIz4Q1YL pV5t0x0eskUB8fT3iR+oARS/bSKYKcT2U+fEFOKf5Qpyw0erICnY6ukhUzX8f+DmDLpC mYL0oGk4tgY31ZgzcrASC9ad6gAenLbN7HrTxM1aH+8gpspyVZtigrAquPX7I93COlR4 tvFQ== X-Gm-Message-State: AOJu0YzGlI7j2skcm++G/ZH9AN/VOX4qwDI9zkvYkLa0yCxq656bBjSV xj6ox8WZ2tijezvVD3a8zXxZAh7SzsZ867QqfSe27Geqzehybkn2 X-Google-Smtp-Source: AGHT+IEmU3HCSQf9aig0KEFXiizSRqNXbEB/avxGC7+cBg8/pQMukd2RHakOmtXV/R1FnA93dDNsxg== X-Received: by 2002:a6b:f007:0:b0:7cb:f759:56c4 with SMTP id w7-20020a6bf007000000b007cbf75956c4mr8329788ioc.10.1711378065693; Mon, 25 Mar 2024 07:47:45 -0700 (PDT) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id fl46-20020a05663863ee00b0047c150766aesm1070130jab.179.2024.03.25.07.47.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Mar 2024 07:47:45 -0700 (PDT) Date: Mon, 25 Mar 2024 09:47:43 -0500 From: Nathan Bossart To: Tom Lane Cc: pgsql-hackers@lists.postgresql.org, alex work , Robert Haas Subject: Re: Slow GRANT ROLE on PostgreSQL 16 with thousands of ROLEs Message-ID: <20240325144743.GA2618709@nathanxps13> References: <20240322005139.GA2060816@nathanxps13> <806361.1711069194@sss.pgh.pa.us> <20240322144739.GA2321246@nathanxps13> <20240322145532.GA2346110@nathanxps13> <907785.1711121266@sss.pgh.pa.us> <20240322163952.GA2347986@nathanxps13> <939945.1711126395@sss.pgh.pa.us> <20240322165448.GA2350322@nathanxps13> <20240322193506.GA2352051@nathanxps13> <1084642.1711140109@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1084642.1711140109@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Mar 22, 2024 at 04:41:49PM -0400, Tom Lane wrote: > Nathan Bossart writes: >> LGTM > > Thanks for looking, I'll push that shortly. Are there any changes you'd like to see for the Bloom patch [0]? I'd like to see about getting that committed for v17. One thing that crossed my mind is creating a combined list/filter that transparently created a filter when necessary (for reuse elsewhere), but I'm not sure that's v17 material. [0] https://postgr.es/m/attachment/158079/bloom_v2.patch -- Nathan Bossart Amazon Web Services: https://aws.amazon.com