Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rpIDL-0061EL-LH for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Mar 2024 01:36:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rpIDJ-008NIT-Un for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Mar 2024 01:36:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rpIDJ-008NIL-JH for pgsql-hackers@lists.postgresql.org; Wed, 27 Mar 2024 01:36:25 +0000 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rpIDC-006cYH-NE for pgsql-hackers@postgresql.org; Wed, 27 Mar 2024 01:36:24 +0000 Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-dcd9e34430cso6425731276.1 for ; Tue, 26 Mar 2024 18:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711503379; x=1712108179; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BKxVUh06AMFD8qvEfVcnnCO+4TUgOWMQ6d/B6wue0gg=; b=jOCIcvf0obyHB9gNaHtADeJpiXNaa+tr7J1d/29TZxPD35Wovw8qdFIhT0U8hFcoZy SXc+fcd2DX4cLF0ceRX7uyx9sv+DX1xdkLIsngxAEEiWmMBY/AoBjik6XjOA1jkn0r7N hEATWVWlJ0VqWEVHImNgFKOOE4Lx9VDxRfE7c6B1MqwUp8EDss9ZspPPz1ABgMaaS6GW lcK0zABBHicd6NseWL3C0mV7IpCy5nsSJ6GAup3jSyiJ/Jynes4xE9WK6ujQkDUAS/Wm emEIGWSsx6TVn221KnaFWkjF+j/q2A/64F3BvcBnEoYmaWD7pvXNYt7z5Mjn5AEpiOWG ScMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711503379; x=1712108179; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BKxVUh06AMFD8qvEfVcnnCO+4TUgOWMQ6d/B6wue0gg=; b=mBm/utB5U48yXrR5/ZgCW3MassFx+KHvWIre+jaVKvo60VtlFMx+7ruT0eoIRZW3hJ RfJRU7KUV54TwDEvFBqcOdb30v8ArsEaQADi3nUSmoANM1baLTLtjZmNGfppThmgPxLF uBWtRlN6aEz11A9WkrafeQ1mMPN5S2uh3mrLGb1e+n75DfLZf7aUgAPQVIfbYk/YVOsL YVjA+yAooF/ziOD78GE5kQ/wXCEZ18XBYwA9sJ6a5zlKBCm7q8tk+3xIUAYRq4my/HPy NA04GNOXu//XBoV8lRe16wnJMPg3Xej4UAEjVeJpFtK1kH1Oa9Urc65kkKA8uplwx/oP 1OxA== X-Forwarded-Encrypted: i=1; AJvYcCUmT5Th8pKiZT1jEn1Ia7TWnaWTRftPtIMlI2JOgaoQiFWDuDyTjKj0Z0z0D6XZHsUMonQTam7HaCY8VG0IYc8EHOCX4BgXLsL3bOQ1 X-Gm-Message-State: AOJu0YwJTD77JZXJF27aGVn02VnA8UTVW3ehlVqb/ss5FCDZsARS3enw chm8IFH+xvzgYCUl6o/7ROr+DxFjjIb9Phh/qKWkvHjibYR1DMrX X-Google-Smtp-Source: AGHT+IHYcA43MjvtlfL5M1InukvVT5rSAN7Bwbd6BNvwyvCxCO63naX2J2WTCvslqcOUHj/q/yIP3g== X-Received: by 2002:a25:6989:0:b0:dbd:120e:f337 with SMTP id e131-20020a256989000000b00dbd120ef337mr2741138ybc.30.1711503378681; Tue, 26 Mar 2024 18:36:18 -0700 (PDT) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id r7-20020a028807000000b0047bff096b1asm2668506jai.23.2024.03.26.18.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Mar 2024 18:36:18 -0700 (PDT) Date: Tue, 26 Mar 2024 20:36:16 -0500 From: Nathan Bossart To: Tom Lane Cc: John Naylor , Ants Aasma , pgsql-hackers@postgresql.org Subject: Re: add AVX2 support to simd.h Message-ID: <20240327013616.GA3940109@nathanxps13> References: <20240320143116.GA1313857@nathanxps13> <20240320195513.GA1618413@nathanxps13> <20240321170944.GA1767527@nathanxps13> <20240325152121.GB2662364@nathanxps13> <20240325213754.GA3094030@nathanxps13> <20240326190904.GA3700674@nathanxps13> <3189995.1711495704@sss.pgh.pa.us> <20240326235554.GA3766883@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240326235554.GA3766883@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Mar 26, 2024 at 06:55:54PM -0500, Nathan Bossart wrote: > On Tue, Mar 26, 2024 at 07:28:24PM -0400, Tom Lane wrote: >> A significant fraction of the buildfarm is issuing warnings about >> this. > > Thanks for the heads-up. Will fix. Done. I'll keep an eye on the farm. I just did the minimal fix for now, i.e., I moved the new label into the SIMD section of the function. I think it would be better stylistically to move the one-by-one logic to an inline helper function, but I didn't do that just in case it might negatively impact performance. I'll look into this and will follow up with another patch if it looks good. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com