Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rpn4J-008dFU-So for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Mar 2024 10:33:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rpn4I-00BKrO-T3 for pgsql-hackers@arkaria.postgresql.org; Thu, 28 Mar 2024 10:33:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rpn4H-00BKrF-JR for pgsql-hackers@lists.postgresql.org; Thu, 28 Mar 2024 10:33:10 +0000 Received: from fout7-smtp.messagingengine.com ([103.168.172.150]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rpn4C-006rXO-Jb for pgsql-hackers@lists.postgresql.org; Thu, 28 Mar 2024 10:33:08 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.nyi.internal (Postfix) with ESMTP id 6D5E61380096; Thu, 28 Mar 2024 06:33:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 28 Mar 2024 06:33:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1711621984; x= 1711708384; bh=CELLheKpPLTqe8W3ltwAIoKdJIsCwLqvpyU2bbMQDIg=; b=u OMI4GoXbl58ZmtawxDbXFcwEoS/uJXOnLUsYhQPsqL9Ivqz/3rnlDuEAecc0cwwg 7vOfQYhghfxEx3/DAIvqWNGsXmKOOZKbX3dk6xrH55kzMjYZITjoGKhLKV6zX5zM x0AYzo9+OhgFeTwADnVm7klKiTehrGcUbyWwIQXvaH187njmEHtOSTtV4p1K+Vb+ ZWPjjHBbgMsTCjYMUCVMx3zhgYgIMZBeRsp7GT6sEKFhCbuF7R4qHBA+/R4J6Eub ri15hE5BrGiOB4zV3wxen4t39VfB/pYKPU6g3zt+WD9qVz3YJkdESOqTdqRxp/L2 fjXHpfhjfD5TYfmHBb0BQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudduledgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Mar 2024 06:33:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1711621980; bh=fUa64mjzczG11V/EzmhQJIjUY35ynT3k7fTJOpJpg4I=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=fw1M5DJKvZVf520PZ8+sgC2fndM7YRxpgpNdCGyW98ydRJOHs65r9AvzeQbXRmwRb e35ucm8SD9++dREQ9ZT8S16hBP+W+J4booIlw39zig/oxnvDdrGpRjsmePFjf+mxt0 xDPWbLedrPqrCJLQAAoovr1Cgoa2kiha4rizjV8Fb/AUV9p1DUHbqKVncxn+nBiY83 Fn075iAVXld0TyD2TPFr3eqLqEsbq02cf1f54UgPLXO2C5RX47Oh2O9cQoDlTgErau iC8+3NnKE4vUqQxr79EnbydGUsuPqSEWv4cq1fThmoxnGIj6Uo/TvIZ3Wd9BjETMVf OG2PcV+dnt+wA== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id 73D393A3; Thu, 28 Mar 2024 11:33:00 +0100 (CET) Date: Thu, 28 Mar 2024 11:33:00 +0100 From: Alvaro Herrera To: Jelte Fennema-Nio Cc: Noah Misch , Jacob Champion , Tom Lane , Denis Laxalde , vignesh C , Thomas Munro , Greg Stark , "Gregory Stark (as CFM)" , Jelte Fennema , Daniel Gustafsson , Peter Eisentraut , Andres Freund , Justin Pryzby , Robert Haas , pgsql-hackers@lists.postgresql.org, Etsuro Fujita Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel Message-ID: <202403281033.m43cmgh5mhz7@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-Mar-28, Jelte Fennema-Nio wrote: > Your changes look good, apart from the prverror stuff indeed. If you > remove the prverror stuff again I think this is ready to commit. Great, thanks for looking. Pushed now, I'll be closing the commitfest entry shortly. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "Always assume the user will do much worse than the stupidest thing you can imagine." (Julien PUYDT)