Feedback-ID: ia2694551:Fastmail
Date: Thu, 28 Mar 2024 13:19:14 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Noah Misch <noah@leadboat.com>,
	Jacob Champion <jacob.champion@enterprisedb.com>,
 Tom Lane <tgl@sss.pgh.pa.us>,
	Denis Laxalde <denis.laxalde@dalibo.com>, vignesh C <vignesh21@gmail.com>,
	Thomas Munro <thomas.munro@gmail.com>, Greg Stark <stark@mit.edu>,
	"Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
 Jelte Fennema <Jelte.Fennema@microsoft.com>,
	Daniel Gustafsson <daniel@yesql.se>, Peter Eisentraut <peter@eisentraut.org>,
	Andres Freund <andres@anarazel.de>, Justin Pryzby <pryzby@telsasoft.com>,
	Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@lists.postgresql.org,
	Etsuro Fujita <etsuro.fujita@gmail.com>
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
Message-ID: <202403281219.nqd5kdqs745z@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202403281115.sy2xffc2ms2d@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/202403281219.nqd5kdqs745z%40alvherre.pgsql>
Precedence: bulk

On 2024-Mar-28, Alvaro Herrera wrote:

> Undefined symbols for architecture arm64:
>   "_libintl_gettext", referenced from:
>       _libpqsrv_cancel in dblink.o
>       _libpqsrv_cancel in dblink.o
> ld: symbol(s) not found for architecture arm64
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
> make[1]: *** [dblink.dylib] Error 1
> make: *** [all-dblink-recurse] Error 2

I just removed the _() from the new function.  There's not much point in
wasting more time on this, given that contrib doesn't have translation
support anyway, and we're not using this in libpqwalreceiver.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Crear es tan difícil como ser libre" (Elsa Triolet)