Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rs33a-004THb-3I for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Apr 2024 16:01:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rs33Y-004BHG-My for pgsql-hackers@arkaria.postgresql.org; Wed, 03 Apr 2024 16:01:44 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rs33X-004BGi-HX for pgsql-hackers@lists.postgresql.org; Wed, 03 Apr 2024 16:01:44 +0000 Received: from wfout3-smtp.messagingengine.com ([64.147.123.146]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rs33Q-000NmA-AM for pgsql-hackers@lists.postgresql.org; Wed, 03 Apr 2024 16:01:42 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfout.west.internal (Postfix) with ESMTP id EF49B1C00092; Wed, 3 Apr 2024 12:01:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 03 Apr 2024 12:01:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712160092; x= 1712246492; bh=PRDPlfBBWOUOwFllMb0dxT0sNSd9Z4bjQbekgPXb9eM=; b=j 3+W0V4+dIFLi44IEJC/nZJW4lpWGDXBXqpRsniSRHHLHN/lmkNDGS2rv8JOuBPyg 5BXPzZKxXSZGjg9BWwsah/QJIlcEUQIN8A2DrZayocUu0LJ69d2RoHtpDcgESzVq ooVcCp4cigZO9094+mb+nVtW/HiQ8xTcGllLezMVJZLnAc+RtxFGG6zbmmNlMi8A yaJ1YtZiPa5tWYaifl6nHYsLcZJqiDo0hq064SugTuch29FmKKfW7Y6BSc8qI1zH c9+jN3opYlFnuKWBsIRFUXhRMVm3HkPEN2Y5HOxR6G0xY35Vs/IxNNdOLf1CmyT4 fuzu0tYxriLSfQRZKyH7w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudefiedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 Apr 2024 12:01:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1712160088; bh=kCR5ShnJqS8qXVIqKF7uwHa5TvrcRFvWmilmnzTgr0s=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=DxzXQpGoDa0RVKsZXsjXI001p4dJVQRfsuqg4Rvnl/xvodIOpvjmXBjQ6vSsXsiH7 NjN5H8UuBbJRnrl70/eL5Fphidj9zFFWxSnSVnHP+JDz9a+M1krWndJUzrUDzFevUT 0EtTu/yDZqLmJbNrtAcHL4Ohtwv6TMVTKMTE8J/k4ErF68p7klSe5A0NOKjr9EcTn0 k5dG1h4TDAL3x2cFFFkPrDNh3ltSDkhsAewt2RqzdDxX3OaOmDHYHmePwz+Z6PWH0O aSEJljc+kxaHDEQ/5UBAgUZMM71P2cJxSV8YvnZ4ONl0h0SXtaisBiBIwPoKH+/uAL N7ThKVI8KX6jg== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id A226341E; Wed, 3 Apr 2024 18:01:28 +0200 (CEST) Date: Wed, 3 Apr 2024 18:01:28 +0200 From: Alvaro Herrera To: Dilip Kumar Cc: Alexander Lakhin , "Andrey M. Borodin" , tender wang , PostgreSQL Hackers , Tomas Vondra Subject: Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock Message-ID: <202404031601.bdk3cws6o36x@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-Apr-03, Dilip Kumar wrote: > Yeah, we missed acquiring the bank lock w.r.t. intervening pages, > thanks for reporting. Your fix looks correct to me. Thanks for the quick review! And thanks to Alexander for the report. Pushed the fix. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "No hay hombre que no aspire a la plenitud, es decir, la suma de experiencias de que un hombre es capaz"