Feedback-ID: ia2694551:Fastmail
Date: Fri, 5 Apr 2024 20:15:16 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Pavel Borisov <pashkin.elfe@gmail.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 Kartyshov Ivan <i.kartyshov@postgrespro.ru>,
	Euler Taveira <euler@eulerto.com>, Thomas Munro <thomas.munro@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
 Amit Kapila <amit.kapila16@gmail.com>,
	Dilip Kumar <dilipbalaut@gmail.com>, Peter Smith <smithpb2250@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: [HACKERS] make async slave to wait for lsn to be replayed
Message-ID: <202404051815.eri4u5q6oj26@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAPpHfdvnaDextc4oV6cajLbq1Om4_q+LE+tSCnk2defY2TKD4w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202404051815.eri4u5q6oj26%40alvherre.pgsql>
Precedence: bulk

Hello,

BTW I noticed that 
https://coverage.postgresql.org/src/backend/commands/waitlsn.c.gcov.html
says that lsn_cmp is not covered by the tests.  This probably indicates
that the tests are a little too light, but I'm not sure how much extra
effort we want to spend.

I'm still concerned that WaitLSNCleanup is only called in ProcKill.
Does this mean that if a process throws an error while waiting, it'll
not get cleaned up until it exits?  Maybe this is not a big deal, but it
seems odd.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Now I have my system running, not a byte was off the shelf;
It rarely breaks and when it does I fix the code myself.
It's stable, clean and elegant, and lightning fast as well,
And it doesn't cost a nickel, so Bill Gates can go to hell."