Feedback-ID: id4a34324:Fastmail
Date: Sun, 7 Apr 2024 17:10:13 -0700
From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Maxim Orlov <orlovmg@gmail.com>, vignesh C <vignesh21@gmail.com>,
	Palak Chaturvedi <chaturvedipalak1911@gmail.com>,
	Jim Nasby <jim.nasby@gmail.com>, pgsql-hackers@postgresql.org,
	Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Subject: Re: Extension Enhancement: Buffer Invalidation in pg_buffercache
Message-ID: <20240408001013.x7x5q45hhu4xecjn@awork3.anarazel.de>
References: <CALfch1890bL5SddyOpZDC8d-jZFOUGCGbOr+_11jLTwwJ_WEOA@mail.gmail.com>
 <CALfch1_s-X3wxeQbYxhXVuWZKBeY5YvU1D+nJxe21ri5iv0qrw@mail.gmail.com>
 <8b8c709a-c7cc-4965-8296-64f549c27501@abcsql.com>
 <3510716d-d3f3-40c8-9f7f-d644171acfb6@gmail.com>
 <a2c3312f-0866-443f-a799-dd76ebf9c7f5@abcsql.com>
 <CALDaNm20+pri5yvEF-4HZqCwRjHB+qjWHLcfanyEjnwgF96z6Q@mail.gmail.com>
 <CA+hUKGL9Y3RgK=SjzSwvUnS4-5RcFEXJ3fwqbLCa9bo8g4uOOg@mail.gmail.com>
 <CACG=ezbBCXaP_KH3N15_tHSwAcCmHQjTyOVsd2o5qG6B_dPzPg@mail.gmail.com>
 <CA+hUKGKGyVjqoaSC7AZrgYKHAk9Nid9G4Ao3ZtL_OtLZDb+_cA@mail.gmail.com>
 <CA+hUKG+CjngU9+7mfPsV6tA8Rze9keoV887mHxUL_9qiFUrjJA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+hUKG+CjngU9+7mfPsV6tA8Rze9keoV887mHxUL_9qiFUrjJA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/20240408001013.x7x5q45hhu4xecjn%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2024-04-07 11:07:58 +1200, Thomas Munro wrote:
> I thought of a better name for the bufmgr.c function though:
> InvalidateUnpinnedBuffer().  That name seemed better to me after I
> festooned it with warnings about why exactly it's inherently racy and
> only for testing use.

I still dislike that, fwiw, due to the naming similarity to
InvalidateBuffer(), which throws away dirty buffer contents too. Which
obviously isn't acceptable from "userspace".  I'd just name it
pg_buffercache_evict() - given that the commit message's first paragraph uses
"it is useful to be able to evict arbitrary blocks" that seems to describe
things at least as well as "invalidate"?

Greetings,

Andres Freund