public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Pavel Borisov <[email protected]>
Cc: Alexander Korotkov <[email protected]>
Cc: Japin Li <[email protected]>
Cc: Mark Dilger <[email protected]>
Cc: [email protected]
Cc: Michael Paquier <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: Robert Haas <[email protected]>
Subject: Re: Table AM Interface Enhancements
Date: Mon, 8 Apr 2024 09:08:51 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAPpHfdvz22sHkg7VpFB-XN1eZN6VfBY6mJc7zNa4aHZw+RqRXg@mail.gmail.com>
	<ME3P282MB3166C45F15AB60418656CD7FB63B2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM>
	<CALT9ZEH+RwH3DONih5VtxQBBqeeshFYJYXSA-vJSAXB0vfYwsA@mail.gmail.com>
	<CALT9ZEFHbEok=F6MUD+9vGFC9O+zah3dYJg1iKFLrHnPbnP_Dw@mail.gmail.com>
	<CALT9ZEEa=CQE2N+tY68yYr2Cp7GxOxWL3pQneDcsqkiWKoSb5Q@mail.gmail.com>
	<CAPpHfdsmziv-+B3_7Va4ydkL9E-vh4RZF9qRR1oQiSqLHB4qpA@mail.gmail.com>
	<[email protected]>
	<CAPpHfduoywCT5iBcmp3bXiRsNUuBnjAkDDCjhzo6rDvqfdgMHg@mail.gmail.com>
	<CALT9ZEF2m6U7NeTnbiRJvONPQr6mMvQM4ZY+3U_7BAggupiywA@mail.gmail.com>
	<[email protected]>

On 2024-04-08 08:37:44 -0700, Andres Freund wrote:
> On 2024-04-08 11:17:51 +0400, Pavel Borisov wrote:
> > On Mon, 8 Apr 2024 at 03:25, Alexander Korotkov <[email protected]>
> > > I was under the impression there are not so many out-of-core table
> > > AMs, which have non-dummy analysis implementations.  And even if there
> > > are some, duplicating acquire_sample_rows() isn't a big deal.
> > >
> > > But given your feedback, I'd like to propose to keep both options
> > > open.  Turn back the block-level API for analyze, but let table-AM
> > > implement its own analyze function.  Then existing out-of-core AMs
> > > wouldn't need to do anything (or probably just set the new API method
> > > to NULL).
> > >
> > I think that providing both new and old interface functions for block-based
> > and non-block based custom am is an excellent compromise.
>
> I don't agree, that way lies an unmanageable API. To me the new API doesn't
> look well polished either, so it's not a question of a smoother transition or
> something like that.
>
> I don't think redesigning extension APIs at this stage of the release cycle
> makes sense.

Wait, you already pushed an API redesign? With a design that hasn't even seen
the list from what I can tell? Without even mentioning that on the list? You
got to be kidding me.

view thread (62+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Table AM Interface Enhancements
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox