public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nathan Bossart <[email protected]>
To: David Rowley <[email protected]>
Cc: PostgreSQL Developers <[email protected]>
Subject: Re: Fixup some StringInfo usages
Date: Mon, 8 Apr 2024 20:34:12 -0500
Message-ID: <20240409013412.GA1431559@nathanxps13> (raw)
In-Reply-To: <CAApHDvojY2UvMiO+9_55ArTj10P1LBNJyyoGB+C65BLDNT0GsQ@mail.gmail.com>
References: <CAApHDvojY2UvMiO+9_55ArTj10P1LBNJyyoGB+C65BLDNT0GsQ@mail.gmail.com>

On Tue, Apr 09, 2024 at 12:53:21PM +1200, David Rowley wrote:
> Similar to f736e188c, I've attached a patch that fixes up a few
> misusages of the StringInfo functions. These just swap one function
> call for another function that is more suited to the use case.
> 
> I've also attached the patch that I used to find these.  That's not
> intended for commit.
> 
> I feel like it's a good idea to fix these soon while they're new
> rather than wait N years and make backpatching bug fixes possibly
> harder.
> 
> I've attached a file with git blame commands to identify where all of
> these were introduced.  All are new to PG17.
> 
> Any objections?

Looks reasonable to me.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Fixup some StringInfo usages
  In-Reply-To: <20240409013412.GA1431559@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox