Date: Tue, 9 Apr 2024 13:41:15 +0200
From: Ole Peder =?utf-8?Q?Brandtz=C3=A6g?= <olebra@samfundet.no>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: NumericShort vs NumericLong format
Message-ID: <20240409114115.opvkgfnhejxbffbv@samfundet.no>
References: <CAF-KA8_Uf_LZ1krmNdiSJtCoMqSzjdjQRFc=ZK=fQoOFKShF-Q@mail.gmail.com>
 <CAKFQuwbUxr-u2BT2PQ4Q_n_o0DieipneHQE+VEPML96bnR3HDQ@mail.gmail.com>
 <3804660.1678166127@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3804660.1678166127@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/20240409114115.opvkgfnhejxbffbv%40samfundet.no>
Precedence: bulk

On Tue, Mar 07, 2023 at 12:15:27AM -0500, Tom Lane wrote:
> "David G. Johnston" <david.g.johnston@gmail.com> writes:
> > As an aside, for anyone more fluent than I who reads this, is the use of
> > the word "dynamic scale" in this code comment supposed to be "display
> > scale"?
> > https://github.com/postgres/postgres/blob/cf96907aadca454c4094819c2ecddee07eafe203/src/backend/utils/adt/numeric.c#L121
> 
> Yeah, I think you're right.

Familiarizing myself with numeric.c today, I too was confused by this.
AFAICT, it's meant to say display scale as used elsewhere in the file;
for instance, the comment for NumericShort's n_header reads "Sign +
display scale + weight". Would it be appropriate if I submitted a patch
for this? It's admittedly trivial, but I figured I should say hi before
submitting one.

All the best,
Ole

-- 
Ole Peder Brandtzæg | En KLST/ITK-hybrid
Please don't look at me with those eyes
Please don't hint that you're capable of lies