Date: Fri, 12 Apr 2024 13:40:00 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: "Imseih (AWS), Sami" <simseih@amazon.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: allow changing autovacuum_max_workers without restarting
Message-ID: <20240412184000.GA2416270@nathanxps13>
References: <20240410212344.GA1824549@nathanxps13>
 <D04DFE2E-290F-43BA-9368-952F2B85E0C2@amazon.com>
 <20240411144240.GD1882158@nathanxps13>
 <66B70E79-54C0-4E58-831D-502B4B97E33D@amazon.com>
 <20240411192423.GB2005410@nathanxps13>
 <DC833F51-881A-47F9-AEF6-B2E1DE46CDC8@amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DC833F51-881A-47F9-AEF6-B2E1DE46CDC8@amazon.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20240412184000.GA2416270%40nathanxps13>
Precedence: bulk

On Fri, Apr 12, 2024 at 05:27:40PM +0000, Imseih (AWS), Sami wrote:
> A few comments on  the POC patch:

Thanks for reviewing.

> 1/ We should emit a log when autovacuum_workers is set higher than the max.

Hm.  Maybe the autovacuum launcher could do that.

> 2/ should the name of the restart limit be "reserved_autovacuum_workers"?

That's kind-of what I had in mind, although I think we might want to avoid
the word "reserved" because it sounds a bit like reserved_connections and
superuser_reserved_connections.  "autovacuum_max_slots" or
"autovacuum_max_worker_slots" might be worth considering, too.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com