Feedback-ID: id4a34324:Fastmail
Date: Wed, 17 Apr 2024 10:21:34 -0700
From: Andres Freund <andres@anarazel.de>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>,
	Andrew Dunstan <andrew@dunslane.net>,
	Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: documentation structure
Message-ID: <20240417172134.4qeuadt7kyg6ewfi@awork3.anarazel.de>
References: <CA+TgmoZ2F+K0j=6BOJLD=YfpJMdJRXC7sWmtXGRjx1Rq0x8PUA@mail.gmail.com>
 <CAD5tBcJUVQu=9zpr9C+Z=3SjxrECURtr_i1oipMqke4dpZXtyQ@mail.gmail.com>
 <20240416182310.2j6g5fqqcwi4s6wm@awork3.anarazel.de>
 <1355791.1713294332@sss.pgh.pa.us>
 <Zh7RmdqvbTjKceHL@momjian.us>
 <CADkLM=eohgf7TjMRccP+k37+vvcmbi+iRQHQX-ubqtFZYsd6cA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CADkLM=eohgf7TjMRccP+k37+vvcmbi+iRQHQX-ubqtFZYsd6cA@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/20240417172134.4qeuadt7kyg6ewfi%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2024-04-17 02:46:53 -0400, Corey Huinker wrote:
> > > This sounds to me like it would be a painful exercise with not a
> > > lot of benefit in the end.
> >
> > Maybe we could _verify_ the contents of func.sgml against pg_proc.
> >
> 
> All of the functions redefined in catalog/system_functions.sql complicate
> using pg_proc.dat as a doc generator or source of validation. We'd probably
> do better to validate against a live instance, and even then the benefit
> wouldn't be great.

There are 80 'CREATE OR REPLACE's in system_functions.sql, 1016 occurrences of
func_table_entry in funcs.sgml and 3.3k functions in pg_proc. I'm not saying
that differences due to system_functions.sql wouldn't be annoying to deal
with, but it'd also be far from the end of the world.

Greetings,

Andres Freund