Date: Wed, 24 Apr 2024 18:47:36 +0900
From: Yugo NAGATA <nagata@sraoss.co.jp>
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: minor error message inconsistency in make_pathkey_from_sortinfo
Message-Id: <20240424184736.d16803a87d6c8a22088e0a2b@sraoss.co.jp>
In-Reply-To: <CACJufxGNJqR79WEwBRw9g2DB-6WhNcJs1uuG7KnTGA5ouM6eug@mail.gmail.com>
References: <CACJufxGNJqR79WEwBRw9g2DB-6WhNcJs1uuG7KnTGA5ouM6eug@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20240424184736.d16803a87d6c8a22088e0a2b%40sraoss.co.jp>
Precedence: bulk

On Wed, 24 Apr 2024 15:05:00 +0800
jian he <jian.universality@gmail.com> wrote:

> hi.
> 
> in make_pathkey_from_sortinfo
> 
> equality_op = get_opfamily_member(opfamily,
>   opcintype,
>   opcintype,
>   BTEqualStrategyNumber);
> if (!OidIsValid(equality_op)) /* shouldn't happen */
> elog(ERROR, "missing operator %d(%u,%u) in opfamily %u",
> BTEqualStrategyNumber, opcintype, opcintype, opfamily);
> 
> the error message seems not right?

This message was introduced by 278cb434110 which was aiming to
standardize the wording for similar errors. We can find the pattern

 "missing {support function | operator} %d(%u,%u) in opfamily %u"

in several places.

Regards,
Yugo Nagata

> 
> maybe
> if (!OidIsValid(equality_op)) /* shouldn't happen */
> elog(ERROR, "missing operator =(%u,%u) in opfamily %u",opcintype,
> opcintype, opfamily);
> 
> or
> 
> if (!OidIsValid(equality_op)) /* shouldn't happen */
> elog(ERROR, "missing equality operator for type %u in opfamily
> %u",opcintype, opcintype, opfamily);
> 
> 


-- 
Yugo NAGATA <nagata@sraoss.co.jp>