Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzugE-007v8N-4b for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Apr 2024 08:42:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rzugC-004nko-Gn for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Apr 2024 08:42:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzugC-004nkf-7H for pgsql-hackers@lists.postgresql.org; Thu, 25 Apr 2024 08:42:08 +0000 Received: from ml.sraoss.co.jp ([66.11.59.17]) by magus.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rzug5-002r1R-ST for pgsql-hackers@postgresql.org; Thu, 25 Apr 2024 08:42:06 +0000 Received: from sranhm.sraoss.co.jp (unknown [192.168.174.164]) by osspc26.sraoss.co.jp (Postfix) with ESMTP id 926C82F0010A; Thu, 25 Apr 2024 17:41:57 +0900 (JST) Received: from yugon-CFSV7-1 (unknown [192.168.176.3]) by sranhm.sraoss.co.jp (Postfix) with SMTP id 5DAFB34168F; Thu, 25 Apr 2024 17:41:56 +0900 (JST) Date: Thu, 25 Apr 2024 17:41:55 +0900 From: Yugo NAGATA To: Peter Eisentraut Cc: Tom Lane , pgsql-hackers@postgresql.org Subject: Re: Remove unnecessary code rom be_lo_put() Message-Id: <20240425174155.79e286c508e6f0b827feccef@sraoss.co.jp> In-Reply-To: <6aa7bb40-ff8c-46ec-9165-e932e4f585c1@eisentraut.org> References: <20240424185932.9789628b99a49ec81b020425@sraoss.co.jp> <58c20beb-6b2d-4a70-875c-3b39242abbbd@eisentraut.org> <3683459.1713965109@sss.pgh.pa.us> <6aa7bb40-ff8c-46ec-9165-e932e4f585c1@eisentraut.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, 25 Apr 2024 10:26:41 +0200 Peter Eisentraut wrote: > On 24.04.24 15:25, Tom Lane wrote: > > Peter Eisentraut writes: > >> On 24.04.24 11:59, Yugo NAGATA wrote: > >>> I noticed that a permission check is performed in be_lo_put() > >>> just after returning inv_open(), but teh permission should be > >>> already checked in inv_open(), so I think we can remove this > >>> part of codes. I attached a patch for this fix. > > > >> Yes, I think you are right. > > > > I agree. Do you want to do the honors? > > done > Thank you! Regards, Yugo Nagata -- Yugo NAGATA