Feedback-ID: ia2694551:Fastmail
Date: Sun, 28 Apr 2024 21:16:48 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, 
	Greg Sabino Mullane <htamfids@gmail.com>, pgsql-hackers@lists.postgresql.org, 
	Magnus Hagander <magnus@hagander.net>
Subject: Re: Tarball builds in the new world order
Message-ID: <202404281916.cpngjkjnosj2@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <15181.1714159448@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/202404281916.cpngjkjnosj2%40alvherre.pgsql>
Precedence: bulk

On 2024-Apr-26, Tom Lane wrote:

> --- mk-one-release.orig	2024-04-23 17:30:08.983226671 -0400
> +++ mk-one-release	2024-04-26 15:17:29.713669677 -0400
> @@ -39,13 +39,17 @@ mkdir pgsql
>  git archive ${gitref} | tar xf - -C pgsql
>  
>  # Include the git ref in the output tarballs
> +# (This has no effect with v17 and up; instead we rely on "git archive"
> +# to include the commit hash in the tar header)
>  echo ${gitref} >pgsql/.gitrevision

Why is it that the .gitrevision file is only created here, instead of
being added to the tarball that "git archive" produces?  Adding an
argument like
	--add-virtual-file $(distdir)/.gitrevision:$(GIT_REFSPEC)

to the git archive call should suffice.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"I can't go to a restaurant and order food because I keep looking at the
fonts on the menu.  Five minutes later I realize that it's also talking
about food" (Donald Knuth)