Date: Sun, 12 May 2024 19:11:11 +0900 (JST)
Message-Id: <20240512.191111.1213825596847583935.t-ishii@sranhm.sra.co.jp>
To: byavuz81@gmail.com
Cc: pgsql-hackers@postgresql.org, thomas.munro@gmail.com
Subject: Re: CFbot does not recognize patch contents
From: Tatsuo Ishii <ishii@sraoss.co.jp>
In-Reply-To: <CAN55FZ3QrZ2-yO_siWnNEEgEPshCXaSsZ1E1VVfxm6di-ybm-w@mail.gmail.com>
References: <20240512.155006.1316723460000187647.t-ishii@sranhm.sra.co.jp>
	<CAN55FZ3QrZ2-yO_siWnNEEgEPshCXaSsZ1E1VVfxm6di-ybm-w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20240512.191111.1213825596847583935.t-ishii%40sranhm.sra.co.jp>
Precedence: bulk

> I am able to apply all your patches. I found that a similar thing
> happened before [0] and I guess your case is similar. Adding Thomas to
> CC, he may be able to help more.

Ok. Thanks for the info.

> Nitpick: There is a trailing space warning while applying one of your patches:
> Applying: Row pattern recognition patch (docs).
> .git/rebase-apply/patch:81: trailing whitespace.
>  company  |   tdate    | price | first_value | max | count

Yes, I know. The reason why there's a trailing whitespace is, I copied
the psql output and pasted it into the docs. I wonder why psql adds
the whitespace. Unless there's a good reason to do that, I think it's
better to fix psql so that it does not emit trailing spaces in its
output.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp