Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s7KK9-0052dN-0E for pgsql-hackers@arkaria.postgresql.org; Wed, 15 May 2024 19:30:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1s7KK8-005Vip-KC for pgsql-hackers@arkaria.postgresql.org; Wed, 15 May 2024 19:30:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s7KK8-005Vih-AG for pgsql-hackers@lists.postgresql.org; Wed, 15 May 2024 19:30:00 +0000 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1s7KK4-000PtE-II for pgsql-hackers@postgresql.org; Wed, 15 May 2024 19:29:59 +0000 Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-36c7bd2586eso2765385ab.0 for ; Wed, 15 May 2024 12:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715801395; x=1716406195; darn=postgresql.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vkVzL+/OrR7LI2pOKVn9pL/nql+s70w4HiJC4RoC6CA=; b=e26gStP6Y7lAoaG35k+sOigGbW3kyocAJxeWwPJypBX7j1UKiGvmNo9rhsFso75kat hKvPZlxqUWxrS2LoQKILC37glwLq2UI1opLD2/ej2g6OW4VBtsqtst1I6WUIM5qhYp1T ajmFXiH2yyZlWDgofv3VKHCf+Y4pGtiECMuByF5EJBPa8B9aB5f87CN72iBBkkecH3Hr sYmJUjgAc6C1J05mws6I9xvh/JlryxXse9OfAntOhlJDxBI+f/adZRS6SODssIKgUCdT ProKQhU60e8O0HkYQXJ8+vLGbh2UHpPp7uJSPhevg/jPtwSmM2YCThxuWHChhwtqKJMU tQwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715801395; x=1716406195; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vkVzL+/OrR7LI2pOKVn9pL/nql+s70w4HiJC4RoC6CA=; b=E++oM0DDgMQj/EsMN9WsS4ffsydIboixAD1Wg9NR7APNT/QragIBnQBVPwjmuxARHZ B67mHEBsJUVOwVPcSw/2XF3OSwgCeHsweKZ32A9hWhFKWDCfopUaIiIrMht5bPUSoEVv PjDhhDUb321hYl0O7Gqtm5qf6RCpqgwPNPVd7cKqZENlLr3piglsCfFVibMyenHvnomj UCxOqaUjPJNZJmDBEMuBriF6sa1YPopkpr/gEd+joCdipX4HIzpPD+9WZehnztBSpPGj 8aSdzrq9FMhbMXiwK43tGdKhrsMgdTWvSpTQAqSz27dw1EB8S/ztx/OK41C90EnSotPn IbqA== X-Forwarded-Encrypted: i=1; AJvYcCUsfDWdkOEVIVHA7VfZTF1rawtbqJsHjrMWWPu197KVJRzTrHaKURdVNqSQbBrGQoSQheiaw8OfrxuYvKvw+IMC3pmRdWEkfd4MUG1U X-Gm-Message-State: AOJu0YwzsCCN5SfTzl5XNPnGIAA5LUIqQ4RXwpkJH1D5s5pDhe26HoRy y1qYeeCUtqrK9Qr2l0W+UFROnvpZnLrvcxYmfl4DZKwukqCHJoie X-Google-Smtp-Source: AGHT+IFe1d07DveyY3Imzj7IxPrzXF7CMPsffnIWqf3pT+a6MsFCgV2XIEaFR/K65pH2QENNRhjx5A== X-Received: by 2002:a05:6e02:1d9a:b0:36c:5023:2334 with SMTP id e9e14a558f8ab-36cc1501cd1mr193186255ab.30.1715801395352; Wed, 15 May 2024 12:29:55 -0700 (PDT) Received: from nathanxps13 (162-195-168-172.lightspeed.stlsmo.sbcglobal.net. [162.195.168.172]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-489371417e9sm3732306173.68.2024.05.15.12.29.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 May 2024 12:29:55 -0700 (PDT) Date: Wed, 15 May 2024 14:29:52 -0500 From: Nathan Bossart To: Robert Haas Cc: Tom Lane , pgsql-hackers@postgresql.org Subject: Re: Why does pgindent's README say to download typedefs.list from the buildfarm? Message-ID: <20240515192952.GA1428991@nathanxps13> References: <20240422192218.GB367217@nathanxps13> <3154983.1713816488@sss.pgh.pa.us> <20240422202010.GA420168@nathanxps13> <20240423200455.GA850264@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, May 15, 2024 at 12:06:03PM -0400, Robert Haas wrote: > What jumps out at me when I read this patch is that it says that an > incremental run should do steps 1-3 of a complete run, and then > immediately backtracks and says not to do step 2, which seems a little > strange. > > I played around with this a bit and came up with the attached, which > takes a slightly different approach. Feel free to use, ignore, etc. This is much cleaner, thanks. The only thing that stands out to me is that the "once per release cycle" section should probably say to do an indent run after downloading the typedef file. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com