Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s7iUL-0070be-7f for pgsql-hackers@arkaria.postgresql.org; Thu, 16 May 2024 21:18:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1s7iUL-00G3vF-5l for pgsql-hackers@arkaria.postgresql.org; Thu, 16 May 2024 21:18:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s7iUK-00G3v7-LN for pgsql-hackers@lists.postgresql.org; Thu, 16 May 2024 21:18:08 +0000 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1s7iUH-000bNN-E5 for pgsql-hackers@lists.postgresql.org; Thu, 16 May 2024 21:18:08 +0000 Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3c9995562fcso376483b6e.2 for ; Thu, 16 May 2024 14:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; t=1715894284; x=1716499084; darn=lists.postgresql.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v00WTc5pQnazB3+1OSWgYEOk8ysVkEuCAqEhGqRK6ls=; b=K4Mn+otVUFkac9Cgh1E4tfzUjYqO8Vkl1AZJp483eq1EkPU1prmAQgjKl2nCCKfycD +c2n3JJam/YAjD1qGUXgYFJcyq0nTGV4MdvQYhPPpjiHdpyEvltd9+DrcoPjh7aJ3FAE bb0nDhCu5MJkZkX0DLBhBcGsTqXsNpe7jSV5I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715894284; x=1716499084; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v00WTc5pQnazB3+1OSWgYEOk8ysVkEuCAqEhGqRK6ls=; b=fzbH+cimS0p/z5wK11AswwQBwgCybUKxFf9WHorbDOly4SiBN+wnK1IGkB6P3vruwq 12A9tvkoFACYV0ral1bi2jfeDtQE4edeq467T7ZUFm9Kr5NaTzmex0mRl5oCqaaHdRPJ SeahToPyJ7y2FZ2BGUxia07cXTF2wtIjvP3LpUB/QAttzBrPO1hIN/ZYF2ZmiUjidzHA JWN/OrkmDyIRNNVppzh0JNW8ZW7Y+2aJK+wjoR72nfJfAeZnCBAFMRXFjqaOlXHtdBCH X59eOhj/lwsw/kDeoY0tznBBNNZR2Qdb9+SdA3KLtZckm6uYvdTePmKlr6a7hngSkxUP siuQ== X-Gm-Message-State: AOJu0YxOFv0zXIljXEikuQsU9tCVHN1STay3KbZfKxkM8hFUiXN0SmHg TPcpvuDy76IJ+iCzjemfJ3j8yx+hMIHKmhwrO7ZgD5jo0yvbzoPdpkgBsezfisz1Uhl+iGmEF9v M4A== X-Google-Smtp-Source: AGHT+IGUVnque5Y8V5ZtV4eGHTK0a+p2pPaAGu9WKDUgHjjkjiaBhVN6UbB01FSw2RhN9k8Fgncozg== X-Received: by 2002:a05:6870:4349:b0:21e:b8f7:9a1b with SMTP id 586e51a60fabf-24172bc59fbmr21856026fac.25.1715894284175; Thu, 16 May 2024 14:18:04 -0700 (PDT) Received: from google.com ([2600:1702:a20:5750::48]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-6f0e022339dsm2828529a34.62.2024.05.16.14.18.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 May 2024 14:18:03 -0700 (PDT) Date: Thu, 16 May 2024 14:18:01 -0700 From: Noah Misch To: Kirill Reshke , Amit Kapila Cc: PostgreSQL Hackers Subject: Re: TerminateOtherDBBackends code comments inconsistency. Message-ID: <20240516211801.8d.nmisch@google.com> References: <20240422162639.68@rfd.leadboat.com> <20240429212756.60.nmisch@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Apr 30, 2024 at 09:10:52AM +0530, Amit Kapila wrote: > On Tue, Apr 30, 2024 at 2:58 AM Noah Misch wrote: > > On Mon, Apr 29, 2024 at 10:18:35AM +0530, Amit Kapila wrote: > > > 3a9b18b309 didn't change the docs of pg_terminate_backend and whatever > > > is mentioned w.r.t permissions in the doc of that function sounds > > > valid for drop database force to me. Do you have any specific proposal > > > in your mind? > > > > Something like the attached. > > LGTM. Pushed as commit 372700c. Thanks for the report and the review.