Date: Tue, 04 Jun 2024 16:44:09 +0900 (JST)
Message-Id: <20240604.164409.1964339778483522274.horikyota.ntt@gmail.com>
To: songlong88@126.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PATCH]A minor improvement to the error-report in
 SimpleLruWriteAll()
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <5b5d9c66.a708.18fbf20f618.Coremail.songlong88@126.com>
References: <4b07eb8f.27a6.18faf1164a5.Coremail.songlong88@126.com>
	<5b5d9c66.a708.18fbf20f618.Coremail.songlong88@126.com>
User-Agent: Mew version 6.8 on Emacs 27.2
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20240604.164409.1964339778483522274.horikyota.ntt%40gmail.com>
Precedence: bulk

At Tue, 28 May 2024 20:15:59 +0800 (CST), "Long Song" <songlong88@126.com> wrote in 
> 
> Hi,
> Actually, I still wonder why only the error message
> of the last failure to close the file was recorded.
> For this unusual situation, it is acceptable to
> record all failure information without causing
> too much logging.
> Was it designed that way on purpose?

Note that SlruReportIOError() causes a non-local exit. To me, the
point of the loop seems to be that we want to close every single file,
apart from the failed ones. From that perspective, the patch disrupts
that intended behavior by exiting in the middle of the loop. It seems
we didn't want to bother collecting errors for every failed file in
that part.
 
regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center