Date: Wed, 05 Jun 2024 13:12:41 +0900 (JST)
Message-Id: <20240605.131241.1337361574087593814.horikyota.ntt@gmail.com>
To: ranier.vf@gmail.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: Fix use of possible uninitialized variable retval
 (src/pl/plpgsql/src/pl_handler.c)
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <CAEudQAoDXrVNV8M9q2k4xycxuBrebh0NRPECXFa1N-Z8q-B7ww@mail.gmail.com>
References: <CAEudQAoDXrVNV8M9q2k4xycxuBrebh0NRPECXFa1N-Z8q-B7ww@mail.gmail.com>
User-Agent: Mew version 6.8 on Emacs 27.2
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20240605.131241.1337361574087593814.horikyota.ntt%40gmail.com>
Precedence: bulk

At Mon, 27 May 2024 11:31:24 -0300, Ranier Vilela <ranier.vf@gmail.com> wrote in 
> Hi.
> 
> The function *plpgsql_inline_handler* can use uninitialized
> variable retval, if PG_TRY fails.
> Fix like function*plpgsql_call_handler* wich declare retval as
> volatile and initialize to (Datum 0).

If PG_TRY fails, retval is not actually accessed, so no real issue
exists. Commit 7292fd8f1c changed plpgsql_call_handler() to the
current form, but as stated in its commit message, it did not fix a
real issue and was solely to silence compiler.

I believe we do not need to modify plpgsql_inline_handler() unless
compiler actually issues a false warning for it.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center