Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sFIS5-000w3T-0U for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Jun 2024 19:07:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sFIS3-00366f-JA for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Jun 2024 19:07:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sFIS3-00366X-9f for pgsql-hackers@lists.postgresql.org; Thu, 06 Jun 2024 19:07:08 +0000 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1sFIS1-0002cY-Tt for pgsql-hackers@postgresql.org; Thu, 06 Jun 2024 19:07:06 +0000 Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-6f956b7ad53so128288a34.3 for ; Thu, 06 Jun 2024 12:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; t=1717700825; x=1718305625; darn=postgresql.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qSn8oiab6ff8Ec49ZeHts3jeEhi4Hcg56Z5prS5GmFo=; b=PNwZ8hPMNjBjLg6+rWzP2hu58iw7zPWnoOJBc7nDVCWZdEFNWhxAdHepUV9eKF/tWf b+Igxrb0ou3/Eo7Lcz3bByjfjlRWqzcA7jNFnq+GCJlbISurewqcm8o/VIcTOIPTH/V6 6U+Lj0ciS+eGVYU6COZG9VOYlKava3tdkng4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717700825; x=1718305625; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qSn8oiab6ff8Ec49ZeHts3jeEhi4Hcg56Z5prS5GmFo=; b=WB8J/OEoKz+FYNuzhJtvTj/KRmvmnm/lG7EW15VIv+D5cw5XoTQZroKlaQZ1ZyEKc9 v1djxkK5bgdkV6pQhoA0mGxKcMWs/bKeVC6M6jA0u66DLJqyhSSxWlIvnGoGg6MaT3GQ oPNA5a8qS9flAK7P6hN1hCixDIAQR0NH70FUBP6Z0fywHrlSrFwh5kJgAk2iF1NifZlX pIRZEG6grl0BAn4sdIVLCQyKyWK6ZPKVGCsWNgTqk/VYV01lo+c5dZgP2rTBvQ/uY4fD cBLVytUL/LcU5HmjdKQtejxxO2nPo0r/kfNKH+QnFR7jDLMAFbiaOSGvR/EVrWfdJsyP l9/g== X-Forwarded-Encrypted: i=1; AJvYcCX3Zg1fWb8NnbM2kXW40cJNfTAxfUAWVuZTyfMui8BXOHZlHOyZF1VWPXBWNhCiFLxDGPfthTO5MSI5Dj15Az8TdPhULR+Y/u9yQlWB X-Gm-Message-State: AOJu0Yx57dv+YgRswYqJjkFI1xTQBj7cBLfBk9pHkthEklpJkmhR/5lS QyZvgL7Ctmigb1Fu7TV8zeql6NhC9QI3h2U9qzLBYyszSK9Z5GpE3lkuRZJMGQ== X-Google-Smtp-Source: AGHT+IFkuWZHkg1yZB0EpOq8jZbD3/3qtkl/XrfykD0qU0w3rN/bzPf+xrMXcySJJSAm2vWTTGQWOw== X-Received: by 2002:a05:6808:2886:b0:3c7:df4:8fb2 with SMTP id 5614622812f47-3d210db9beamr334298b6e.33.1717700824798; Thu, 06 Jun 2024 12:07:04 -0700 (PDT) Received: from google.com ([2600:1702:a20:5750::48]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3d20b66ca0esm356668b6e.1.2024.06.06.12.07.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jun 2024 12:07:04 -0700 (PDT) Date: Thu, 6 Jun 2024 12:07:02 -0700 From: Noah Misch To: Robert Haas Cc: Alexander Lakhin , pgsql-hackers Subject: Re: Assert in heapgettup_pagemode() fails due to underlying buffer change Message-ID: <20240606190702.cd.nmisch@google.com> References: <7ed10231-ce47-03d5-d3f9-4aea0dc7d5a4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.12 (2023-09-09) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Jun 06, 2024 at 12:36:32PM -0400, Robert Haas wrote: > On Thu, Jun 6, 2024 at 6:00 AM Alexander Lakhin wrote: > > Am I missing something or the the page buffer indeed lacks locking there? > > I don't know, but if the locks are really missing now, I feel like the > first question is "which commit got rid of them?". It's a little hard > to believe that they've never been there and somehow nobody has > noticed. > > Then again, maybe we have; see Noah's thread about in-place updates > breaking stuff and some of the surprising discoveries there. But it > seems worth investigating. $SUBJECT looks more like a duplicate of postgr.es/m/flat/20240512171658.7e.nmisch@google.com (Hot standby queries see transient all-zeros pages).