public inbox for [email protected]  

help / color / mirror / Atom feed

From: Noah Misch <[email protected]>
To: Jelte Fennema-Nio <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Jacob Champion <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: RFC: adding pytest as a supported test framework
Date: Wed, 12 Jun 2024 13:56:57 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAGECzQTEPcLH-Gjr8aTkK=R36_jHU_ikhhan6hO42zCoUNv=yA@mail.gmail.com>
References: <CAOYmi+kThkM9Z87u=R_Wi7fCor2i+UZKAyq0UCyprzCwTQvqgA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAGECzQTEPcLH-Gjr8aTkK=R36_jHU_ikhhan6hO42zCoUNv=yA@mail.gmail.com>

On Wed, Jun 12, 2024 at 01:40:30PM +0200, Jelte Fennema-Nio wrote:
> On Wed, 12 Jun 2024 at 01:48, Noah Misch <[email protected]> wrote:
> > I also want the initial scope to be the new language coexisting with the
> > existing Perl tests.  If a bulk translation ever happens, it should happen
> > long after the debut of the new framework.  That said, I don't much trust a
> > human-written bulk language translation to go through without some tests
> > accidentally ceasing to test what they test in Perl today.
> 
> I definitely don't think we should rewrite all the tests that we have
> in Perl today into some other language. But I do think that whatever
> language we choose, that language should make it as least as easy to
> write tests, as easy to read them and as easy to see that they are
> testing the intended thing, as is currently the case for Perl.
> Rewriting a few Perl tests into the new language, even if not merging
> the rewrite, is a good way of validating that imho.

Agreed.

> PS. For PgBouncer I actually hand-rewrote all the tests that we had in
> bash (which is the worst testing language ever) in Python and doing so
> actually found more bugs in PgBouncer code that our bash tests
> wouldn't catch. So it's not necessarily the case that you lose
> coverage by rewriting tests.

Yep.

view thread (77+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: RFC: adding pytest as a supported test framework
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox