Date: Sun, 30 Jun 2024 12:25:34 -0700
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>,
	Peter Eisentraut <peter@eisentraut.org>,
	Alexander Lakhin <exclusion@gmail.com>,
	Euler Taveira <euler@eulerto.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Shlok Kyal <shlok.kyal.oss@gmail.com>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	"kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
	Michael Paquier <michael@paquier.xyz>,
	Andres Freund <andres@anarazel.de>,
	Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
	=?iso-8859-1?Q?Fabr=EDzio?= de Royes Mello <fabriziomello@gmail.com>,
	vignesh C <vignesh21@gmail.com>
Subject: Re: speed up a logical replica setup
Message-ID: <20240630192534.11.nmisch@google.com>
References: 
 <CAA4eK1KdCb+5sjYu6qCMXXdCX1y_ihr8kFzMozq0=P=auYxgog@mail.gmail.com>
 <CANhcyEV6q1Vhd37i1axUeScLi0UAGVxta1LDa0BV0Eh--TcPMg@mail.gmail.com>
 <CAA4eK1JaQcAZ=n513-4VDW4ujE9T9f007fczNCpVDbg1smhT4g@mail.gmail.com>
 <5da4b286-e570-4341-8262-92d763f6b1a4@app.fastmail.com>
 <776c5cac-5ef5-4001-b1bc-5b698bc0c62a@app.fastmail.com>
 <3c024250-3f13-4f4d-b8e9-55f176db4abf@eisentraut.org>
 <0dffca12-bf17-4a7a-334d-225569de5e6e@gmail.com>
 <2377319.1719766794@sss.pgh.pa.us>
 <2507765.1719772840@sss.pgh.pa.us>
 <2509767.1719773880@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <2509767.1719773880@sss.pgh.pa.us>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20240630192534.11.nmisch%40google.com>
Precedence: bulk

On Sun, Jun 30, 2024 at 02:58:00PM -0400, Tom Lane wrote:
> I wrote:
> > In hopes of moving things along as we approach the v18 branch,
> > I went ahead and pushed Kuroda-san's patches (with a bit of
> > further editorialization).
>=20
> So b3f5ccebd promptly blew up on fairywren [1]:
>=20
> connection error: 'psql: error: unterminated quoted string in connection =
info string'
> while running 'psql -XAtq -d port=3D52984 host=3DC:/tools/nmsys64/tmp/hHg=
_pngw4z dbname=3D'regression\\\\"\\\\=01=02=03=04=05=06=08	=0B=0C=0E=0F=10=
=11=12=13=14=15=16=17=18=19=1A=1B=1C=1D=1E=1F !"#$%&\\'()*+,-\\\\\\\\"\\\\\=
\\\\\\\' -f - -v ON_ERROR_STOP=3D1' at C:/tools/nmsys64/home/pgrunner/bf/ro=
ot/HEAD/pgsql/src/test/perl/PostgreSQL/Test/Cluster.pm line 2124.
>=20
> This shows that the command-line arguments to psql are not getting
> adequately quoted on that platform.  AFAICS, we are relying on
> IPC::Run::run to perform such quoting, and it seems to be
> falling down here.  I wonder what version of IPC::Run fairywren
> is using.

It does look consistent with IPC::Run predating v20220807.0, hence lacking =
the
https://github.com/toddr/IPC-Run/issues/142 fix.  I wondered how this animal
was passing 002_pg_upgrade.pl, but it seems the animal has run TAP suites o=
nly
occasionally.  Passes in the last week were TAP-free.

> [1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dfairywren&d=
t=3D2024-06-30%2018%3A03%3A06