Date: Sun, 30 Jun 2024 15:23:44 -0700
From: Noah Misch <noah@leadboat.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org,
	Joe Conway <mail@joeconway.com>,
	Robert Haas <robertmhaas@gmail.com>
Subject: Re: MAINTAIN privilege -- what do we need to un-revert it?
Message-ID: <20240630222344.db.nmisch@google.com>
References: <d4ccaf3658cb3c281ec88c851a09733cd9482f22.camel@j-davis.com>
 <20240214190226.GA373350@nathanxps13>
 <4d497d82e4516037dc1082d5a62d199ea00d62e7.camel@j-davis.com>
 <20240223213055.GA1805646@nathanxps13>
 <196d1c86d43a147e777bb74159774f255dbe73e3.camel@j-davis.com>
 <20240228165523.GA2435539@nathanxps13>
 <31ae1bf73e8a1dae3ee7ef2dd43a9bbda1e1ab86.camel@j-davis.com>
 <fe5d572b02d07d8e9940f9b518d900708e0b0166.camel@j-davis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fe5d572b02d07d8e9940f9b518d900708e0b0166.camel@j-davis.com>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20240630222344.db.nmisch%40google.com>
Precedence: bulk

On Mon, Mar 04, 2024 at 07:52:05PM -0800, Jeff Davis wrote:
> Committed.

Commit 2af07e2 wrote:
> --- a/src/backend/access/brin/brin.c
> +++ b/src/backend/access/brin/brin.c
> @@ -1412,6 +1412,8 @@ brin_summarize_range(PG_FUNCTION_ARGS)
>  		SetUserIdAndSecContext(heapRel->rd_rel->relowner,
>  							   save_sec_context | SECURITY_RESTRICTED_OPERATION);
>  		save_nestlevel = NewGUCNestLevel();
> +		SetConfigOption("search_path", GUC_SAFE_SEARCH_PATH, PGC_USERSET,
> +						PGC_S_SESSION);

I've audited NewGUCNestLevel() calls that didn't get this addition.  Among
those, these need the addition:

- Each in ComputeIndexAttrs() -- they arise when the caller is DefineIndex()
- In DefineIndex(), after comment "changed a behavior-affecting GUC"

While "not necessary for security", ExecCreateTableAs() should do it for the
same reason it calls NewGUCNestLevel().