Date: Tue, 2 Jul 2024 16:03:33 -0700
From: Noah Misch <noah@leadboat.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Jeff Davis <pgsql@j-davis.com>, Daniel Verite <daniel@manitou-mail.org>,
	Robert Haas <robertmhaas@gmail.com>,
	Jeremy Schneider <schneider@ardentperf.com>,
	pgsql-hackers@postgresql.org
Subject: Re: Built-in CTYPE provider
Message-ID: <20240702230333.8d.nmisch@google.com>
References: <4135cf11-206d-40ed-96c0-9363c1232379@eisentraut.org>
 <7451f81ba0cb512222ab759de8ca1cffe44e9acb.camel@j-davis.com>
 <1f309153-8198-4efa-86dd-8c304ec0040c@eisentraut.org>
 <a21b515000f121244db2a5570d4292d19df23379.camel@j-davis.com>
 <20240629220857.fb.nmisch@google.com>
 <1ecfeb4d2b1b7f119fa917d3052a3aecfaf4f425.camel@j-davis.com>
 <20240701230352.2c.nmisch@google.com>
 <da7a19008c2b1f19b3f91b446fe09847512694f1.camel@j-davis.com>
 <20240702165145.af.nmisch@google.com>
 <1200e97b-3a52-43c6-8b16-20cf45f58249@eisentraut.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1200e97b-3a52-43c6-8b16-20cf45f58249@eisentraut.org>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: <https://www.postgresql.org/message-id/20240702230333.8d.nmisch%40google.com>
Precedence: bulk

On Wed, Jul 03, 2024 at 12:05:09AM +0200, Peter Eisentraut wrote:
> On 02.07.24 18:51, Noah Misch wrote:
> > On Mon, Jul 01, 2024 at 06:19:08PM -0700, Jeff Davis wrote:
> > > On Mon, 2024-07-01 at 16:03 -0700, Noah Misch wrote:
> > > >    An alternative would be to make pg_upgrade reject
> > > > operating on a cluster that contains use of $SUBJECT.
> > > 
> > > That wouldn't help anyone.
> > 
> > Can you say more about that?  For the last decade at least, I think our
> > standard for new features has been to error rather than allow an operation
> > that creates a known path to wrong query results.  I think that's a helpful
> > standard that we should continue to follow.
> 
> I don't think the builtin locale provider is any different in this respect
> from the other providers:  The locale data might change and there is a
> version mechanism to track that.  We don't prevent pg_upgrade in scenarios
> like that for other providers.

Each packager can choose their dependencies so the v16 providers don't have
the problem.  With the $SUBJECT provider, a packager won't have that option.