Feedback-ID: id4a34324:Fastmail
Date: Mon, 8 Jul 2024 17:05:07 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org, Stephen Frost <sfrost@snowman.net>,
	"Jonathan S. Katz" <jkatz@postgresql.org>
Subject: Re: Why do we define HAVE_GSSAPI_EXT_H?
Message-ID: <20240709000507.5zn5z5ankjplgn6c@awork3.anarazel.de>
References: <20240708225659.gmyqoosi7km6ysgn@awork3.anarazel.de>
 <1228648.1720479932@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1228648.1720479932@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/20240709000507.5zn5z5ankjplgn6c%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2024-07-08 19:05:32 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > configure/meson define HAVE_GSSAPI_EXT_H / HAVE_GSSAPI_GSSAPI_EXT_H - but
> > afaict we don't use those anywhere?
> 
> It looks to me like it's just a byproduct of the autoconf macros
> we use to verify that you have a sane installation:
> 
> if test "$with_gssapi" = yes ; then
>   AC_CHECK_HEADERS(gssapi/gssapi.h, [],
> 	[AC_CHECK_HEADERS(gssapi.h, [], [AC_MSG_ERROR([gssapi.h header file is required for GSSAPI])])])
>   AC_CHECK_HEADERS(gssapi/gssapi_ext.h, [],
> 	[AC_CHECK_HEADERS(gssapi_ext.h, [], [AC_MSG_ERROR([gssapi_ext.h header file is required for GSSAPI])])])
> fi
> 
> There might be a variant of AC_CHECK_HEADERS that doesn't have
> the default define-a-symbol action, not sure.

Yep, the singular version doesn't. That's what my attached patch uses...


> Maybe it's not really necessary to check both gssapi.h and
> gssapi_ext.h, but I'm not very familiar with all the variants of
> GSSAPI that are out there.

Me neither. I think it's fine to check both, I am just suggesting not to
define a pg_config.h symbol for both...

Greetings,

Andres Freund