Date: Sat, 13 Jul 2024 14:47:48 -0700
From: Noah Misch <noah@leadboat.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	Nathan Bossart <nathandbossart@gmail.com>,
	pgsql-hackers@postgresql.org, Joe Conway <mail@joeconway.com>,
	Robert Haas <robertmhaas@gmail.com>
Subject: Re: MAINTAIN privilege -- what do we need to un-revert it?
Message-ID: <20240713214748.cb@rfd.leadboat.com>
References: <20240228165523.GA2435539@nathanxps13>
 <31ae1bf73e8a1dae3ee7ef2dd43a9bbda1e1ab86.camel@j-davis.com>
 <fe5d572b02d07d8e9940f9b518d900708e0b0166.camel@j-davis.com>
 <20240630222344.db.nmisch@google.com>
 <ZozWqg0XCkiPCnop@paquier.xyz>
 <23fac3b2a722373a52b92a12ee0f500821450f97.camel@j-davis.com>
 <20240711125207.98.nmisch@google.com>
 <d97b888293e7588164b602850969a4b7d9550cc5.camel@j-davis.com>
 <20240712231149.0d.nmisch@google.com>
 <8e0438821bddd4de198989e6ac0f9a2aa27cabeb.camel@j-davis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8e0438821bddd4de198989e6ac0f9a2aa27cabeb.camel@j-davis.com>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20240713214748.cb%40rfd.leadboat.com>
Precedence: bulk

On Fri, Jul 12, 2024 at 04:50:17PM -0700, Jeff Davis wrote:
> On Fri, 2024-07-12 at 16:11 -0700, Noah Misch wrote:
> > Since refresh->relation is a RangeVar, this departs from the standard
> > against
> > repeated name lookups, from CVE-2014-0062 (commit 5f17304).
> 
> Interesting, thank you.
> 
> I did a rough refactor and attached v3. Aside from cleanup issues, is
> this what you had in mind?

> +extern ObjectAddress RefreshMatViewByOid(Oid matviewOid, bool skipData, bool concurrent,
> +										 const char *queryString, ParamListInfo params,
> +										 QueryCompletion *qc);
>  

Yes, that's an API design that avoids repeated name lookups.