Feedback-ID: ia2694551:Fastmail
Date: Mon, 19 Aug 2024 22:25:13 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tender Wang <tndrwang@gmail.com>
Cc: Junwang Zhao <zhjwpku@gmail.com>,
	Jehan-Guillaume de Rorthais <jgdr@dalibo.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Alexander Lakhin <exclusion@gmail.com>,
 Baehler Thomas SBB CFF FFS <thomas.baehler2@sbb.ch>,
	Guillaume Lelarge <guillaume@lelarge.info>
Subject: Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails
Message-ID: <202408200225.lasmb6pskolh@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAHewXNneHFPG+GmEMamKkXKJgVqBvR-tBjDCpesNAdkehTRdsg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202408200225.lasmb6pskolh%40alvherre.pgsql>
Precedence: bulk

On 2024-Aug-20, Tender Wang wrote:

> > As I understand, this fix needs to be applied all the way back to 12,
> > because the overall functionality is that old.  However, in branches 14
> > and back, the patch doesn't apply cleanly, because of the changes we
> > made in commit f4566345cf40 :-(  I'm tempted to fix it in branches 15,
> > 16, 17, master now and potentially backpatch later, to avoid dragging
> > things along further.  It's taken long enough already.
> 
> I haven't seen this patch on master.  Is there something that we fotget to
> handle?

I haven't pushed it yet, mostly because of being unsure about not doing
anything for the oldest branches (14 and back).

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Java is clearly an example of money oriented programming"  (A. Stepanov)