Date: Tue, 20 Aug 2024 10:26:51 +0200
From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tender Wang <tndrwang@gmail.com>, Junwang Zhao <zhjwpku@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Alexander
 Lakhin <exclusion@gmail.com>, Baehler Thomas SBB CFF FFS
 <thomas.baehler2@sbb.ch>, Guillaume Lelarge <guillaume@lelarge.info>
Subject: Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails
Message-ID: <20240820102651.273ecdf5@karst>
In-Reply-To: <202408072250.2c4fkhwf56lk@alvherre.pgsql>
References: 
 <CAHewXN=ZZ8Jep1kbSUdRXfgyF3V2tgYUGXh04C95uDSuD0rJgg@mail.gmail.com>
	<202408072250.2c4fkhwf56lk@alvherre.pgsql>
Organization: Dalibo
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/20240820102651.273ecdf5%40karst>
Precedence: bulk

On Wed, 7 Aug 2024 18:50:10 -0400
Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:

> On 2024-Jul-26, Tender Wang wrote:
>=20
> > Junwang Zhao <zhjwpku@gmail.com> =E4=BA=8E2024=E5=B9=B47=E6=9C=8826=E6=
=97=A5=E5=91=A8=E4=BA=94 14:57=E5=86=99=E9=81=93=EF=BC=9A
> >=20
> > > There is a bug report[0] Tender comments might be the same issue as
> > > this one, but I tried Alvaro's and mine patch, neither could solve
> > > that problem, I did not tried Tender's earlier patch thought. I post
> > > the test script below in case you are interested.
> >=20
> > My earlier patch should handle Alexander reported case. But I did not
> > do more test. I'm not sure that wether or not has dismatching between
> > pg_constraint and pg_trigger.
> >=20
> > I aggred with Alvaro said that "requires a much more invasive
> > solution".
>=20
> Here's the patch which, as far as I can tell, fixes all the reported
> problems (other than the one in bug 18541, for which I proposed an
> unrelated fix in that thread[1]).  If you can double-check, I would very
> much appreciate that.  Also, I think the test cases the patch adds
> reflect the provided examples sufficiently, but if we're still failing
> to cover some, please let me know.

I'm back on this issue as well. I start poking at this patch to review it,
test it, challenge it and then report here.

I'll try to check if some other issues might have lost/forgot on they way as
well.

In the meantime, thank you Alvaro, Tender and Junwang for your work, time,
research and patches!