Feedback-ID: ia2694551:Fastmail
Date: Tue, 20 Aug 2024 20:13:12 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: "Andrey M. Borodin" <x4mmm@yandex-team.ru>,
	vignesh C <vignesh21@gmail.com>, Andrew Borodin <amborodin86@gmail.com>,
 i.lazarev@postgrespro.ru,
	Yura Sokolov <y.sokolov@postgrespro.ru>, Andres Freund <andres@anarazel.de>,
	Thomas Munro <thomas.munro@gmail.com>, Gilles Darold <gilles@darold.net>,
	Alexander Korotkov <aekorotkov@gmail.com>,
 Anastasia Lubennikova <a.lubennikova@postgrespro.ru>,
	Daniel Gustafsson <daniel@yesql.se>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	pgsql-hackers mailing list <pgsql-hackers@postgresql.org>
Subject: Re: MultiXact\SLRU buffers configuration
Message-ID: <202408210013.knpjya6p656v@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZsUnJUlSOBNAzwW1@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/202408210013.knpjya6p656v%40alvherre.pgsql>
Precedence: bulk

On 2024-Aug-21, Michael Paquier wrote:

> I see that you've gone the way with the SQL function doing a load().
> Would it be worth switching the test to rely on the two macros for
> load and caching instead?  I've mentioned that previously but never
> got down to present a patch for the sake of this test.

Hmm, I have no opinion on which way is best.  You probably have a better
sense of what's better for the injections point interface, so I'm happy
to defer to you on this.

> +	/* reset in case this is a restart within the postmaster */
> +	inj_state = NULL;

I'm not sure that this assignment actually accomplishes anything ...

I don't understand what do the inj_stats_enabled stuff have to do with
this patch.  I suspect it's a git operation error, ie., you seem to have
squashed two different things together.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Industry suffers from the managerial dogma that for the sake of stability
and continuity, the company should be independent of the competence of
individual employees."                                      (E. Dijkstra)