public inbox for [email protected]  

help / color / mirror / Atom feed

From: Yugo Nagata <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: jian he <[email protected]>
Subject: Re: Disallow USING clause when altering type of generated column
Date: Wed, 21 Aug 2024 16:14:02 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Wed, 21 Aug 2024 08:17:45 +0200
Peter Eisentraut <[email protected]> wrote:

> A USING clause when altering the type of a generated column does not 
> make sense.  It would write the output of the USING clause into the 
> converted column, which would violate the generation  expression.
> 
> This patch adds a check to error out if this is specified.

I’m afraid you forgot to attach the patch.
It seems for me that this fix is reasonable though.

Regards,
Yugo Nagata

> 
> There was a test for this, but that test errored out for a different 
> reason, so it was not effective.
> 
> discovered by Jian He at [0]
> 
> [0]: 
> https://www.postgresql.org/message-id/[email protected]...
> 
> 


-- 
Yugo Nagata <[email protected]>

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Disallow USING clause when altering type of generated column
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox