Date: Tue, 3 Sep 2024 11:26:37 +0200
From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Tender Wang <tndrwang@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Junwang Zhao
 <zhjwpku@gmail.com>, "pgsql-hackers@postgresql.org"
 <pgsql-hackers@postgresql.org>, Alexander Lakhin <exclusion@gmail.com>,
 Baehler Thomas SBB CFF FFS <thomas.baehler2@sbb.ch>, Guillaume Lelarge
 <guillaume@lelarge.info>, Michael Paquier <michael@paquier.xyz>
Subject: Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails
Message-ID: <20240903112637.03752732@karst>
In-Reply-To: 
 <CAHewXNk1RvFBPgVgL9PhC2szwMNKTqchZWF9HyN7EXzCuCY4zA@mail.gmail.com>
References: <20240820102651.273ecdf5@karst>
	<202408210309.d5q57gjclpcq@alvherre.pgsql>
	<20240902230147.0d3958bc@karst>
	<CAHewXNk1RvFBPgVgL9PhC2szwMNKTqchZWF9HyN7EXzCuCY4zA@mail.gmail.com>
Organization: Dalibo
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/20240903112637.03752732%40karst>
Precedence: bulk

Hi Tender,

On Tue, 3 Sep 2024 10:16:44 +0800
Tender Wang <tndrwang@gmail.com> wrote:

> Jehan-Guillaume de Rorthais <jgdr@dalibo.com> =E4=BA=8E2024=E5=B9=B49=E6=
=9C=883=E6=97=A5=E5=91=A8=E4=BA=8C 05:02=E5=86=99=E9=81=93=EF=BC=9A
[=E2=80=A6]
> > * Constraint & trigger catalog cleanup [1] (this thread)
> > * FK broken after DETACH [2]
> > * Maintenance consideration about self referencing FK between partitions
> > [3]
> > =20
>=20
> The third issue has been fixed, and codes have been pushed.  Because of my
> misunderstanding,
> It should not be here.

I just retried the SQL scenario Guillaume gave on both master and master wi=
th
Alvaro's patch. See:

https://www.postgresql.org/message-id/flat/CAECtzeWHCA%2B6tTcm2Oh2%2Bg7fURU=
JpLZb-%3DpRXgeWJ-Pi%2BVU%3D_w%40mail.gmail.com

It doesn't seem fixed at all. Maybe you are mixing up with another thread/i=
ssue?

> > 0. Splitting in two commits
> >
> >   [=E2=80=A6]
> >
> >   Unfortunately, this discussion about the first bug slipped to the sec=
ond
> >   one when Tender stumbled on this bug as well and reported it. But, bo=
th
> >   bugs can be triggered independently, and have distinct fixes.
>=20
> It's ok that these two issues are fixed together.  It is  because current
> codes don't handle better when the referenced side is the partition table.

I don't feel the same. Mixing two discussions and fixes together in the same
thread and commit makes life harder.

Last year, when you found the other bug, I tried to point you to the
right thread to avoid mixing subjects:

https://www.postgresql.org/message-id/20230810170345.26e41b05%40karst

If I wrote about the third (non fixed) issue yesterday, it's just because
Alvaro included a reference to it in his commit message. But I think we sho=
uld
really keep up with this issue on its own, dedicated discussion:

https://www.postgresql.org/message-id/flat/CAECtzeWHCA%2B6tTcm2Oh2%2Bg7fURU=
JpLZb-%3DpRXgeWJ-Pi%2BVU%3D_w%40mail.gmail.com

Regards