Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sldYR-000K3c-SS
	for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Sep 2024 00:07:24 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sldYQ-001ZJc-Ae
	for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Sep 2024 00:07:22 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ishii@postgresql.org>)
	id 1sldYP-001ZJT-Ns
	for pgsql-hackers@lists.postgresql.org; Wed, 04 Sep 2024 00:07:22 +0000
Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ishii@postgresql.org>)
	id 1sldYN-000222-F5
	for pgsql-hackers@postgresql.org; Wed, 04 Sep 2024 00:07:21 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=postgresql.org; s=20171124; h=Content-Transfer-Encoding:Content-Type:
	Mime-Version:References:In-Reply-To:From:Subject:Cc:To:Message-Id:Date:Sender
	:Reply-To:Content-ID:Content-Description;
	bh=Eoodx7BCXw9n4Rlm76pHxJTLUIpuYh1aVq7+FEdXulA=; b=b/RZ/5zbfE2b35w7i9qZhxIPxS
	IeZmj5kORijLMAJ6zz47fEOK9YJ1fbJHWpjd7d8skf40AWgEzs/X+KDkI/GCAfeQBb0ttLb4hmkAT
	MAsZUfyadKT1BR88lBErIaOjmeTllRK5TwVRMEbYeXwq5MQQKhU/3yqE4OErlycb8JmVxI+5+jOCz
	nv5hLrE83+lPfD9SCnphP3A98+gEMvD6FyFWY+CAg+hYPzvem9bQ1UlvKKWV/a+MP0Z7ncIEZzy/q
	JGDUdAegMqkFCZNGEkFgD0xcHT1QkZRa/Faifgq95oaebBd4wXsPrYgJGWHhdPjK9sJbfRnggNUWu
	t6eHTf6Q==;
Received: from 185.184.178.217.shared.user.transix.jp ([217.178.184.185]
 helo=localhost)
	by meldrar.postgresql.org with esmtpsa  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256
	(Exim 4.94.2)
	(envelope-from <ishii@postgresql.org>)
	id 1sldYJ-0004ks-NC; Wed, 04 Sep 2024 00:07:19 +0000
Date: Wed, 04 Sep 2024 09:06:57 +0900 (JST)
Message-Id: <20240904.090657.995734319001610943.ishii@postgresql.org>
To: orlovmg@gmail.com
Cc: dgrowleyml@gmail.com, ashutosh.bapat.oss@gmail.com,
 pgsql-hackers@postgresql.org
Subject: Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: 
 <CACG=ezZkhtCzeCkDY=WVYwvsNt0XffRZ7a7x6yH=D14cW=Eo8w@mail.gmail.com>
References: <20240709.154409.1091516017393224028.ishii@postgresql.org>
	<20240710.183610.1211398886785110571.ishii@postgresql.org>
	<CACG=ezZkhtCzeCkDY=WVYwvsNt0XffRZ7a7x6yH=D14cW=Eo8w@mail.gmail.com>
X-Mailer: Mew version 6.8 on Emacs 26.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20240904.090657.995734319001610943.ishii%40postgresql.org>
Precedence: bulk

> Hi!
> 
> +1 for the idea of the patch. Consider it useful.
> 
> I looked at the patch set and don't see any obvious defects. It applies
> without any problems and looks pretty good for me.

Thank you for reviewing my patch.

> Only one thing is left to do. Add basic tests for the added functionality
> to make it committable.  For example, as in the
> mentioned 1eff8279d494b9.

Agreed. Probably add to explain.sql?

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp