public inbox for [email protected]  

help / color / mirror / Atom feed

From: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
Date: Wed, 04 Sep 2024 14:32:27 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA4eK1K0aGmwQarFB=exVd576DLdCyALaKY70oAFn77B1j5a3A@mail.gmail.com>
References: <CAHut+PuvsyA5v8y7rYoY9mkDQzUhwaESM05yCByTMaDoRh30tA@mail.gmail.com>
	<CAJpy0uC6bDq9FhjGP8DnvRgoem1n3Z3ketZKKBg8zi=BMng1DQ@mail.gmail.com>
	<CAA4eK1K0aGmwQarFB=exVd576DLdCyALaKY70oAFn77B1j5a3A@mail.gmail.com>

At Tue, 3 Sep 2024 10:43:14 +0530, Amit Kapila <[email protected]> wrote in 
> On Mon, Sep 2, 2024 at 9:14 AM shveta malik <[email protected]> wrote:
> >
> > On Mon, Sep 2, 2024 at 5:47 AM Peter Smith <[email protected]> wrote:
> > > ----
> > >
> > > To summarize, the current description wrongly describes the field as a
> > > time duration:
> > > "The time since the slot has become inactive."
> > >
> > > I suggest replacing it with:
> > > "The slot has been inactive since this time."
> > >
> >
> > +1 for the change. If I had read the document without knowing about
> > the patch, I too would have interpreted it as a duration.
> >
> 
> The suggested change looks good to me as well. I'll wait for a day or
> two before pushing to see if anyone thinks otherwise.

If possible, I'd prefer to use "the time" as the subject. For example,
would "The time this slot was inactivated" be acceptable? However,
this loses the sense of continuation up to that point, so if that's
crucial, the current proposal might be better.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox