Date: Thu, 19 Sep 2024 09:01:34 +0900 (JST)
Message-Id: <20240919.090134.1961749747398456709.ishii@postgresql.org>
To: dgrowleyml@gmail.com
Cc: ashutosh.bapat.oss@gmail.com, orlovmg@gmail.com,
 jian.universality@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: 
 <CAApHDvr7Ysn0u=8J7yZ+cSFJcKpH_b+MNGt6ZVyMyqr97ym2tg@mail.gmail.com>
References: <20240917.150626.1951146285916205741.ishii@postgresql.org>
	<20240918.211246.1127161704188186085.ishii@postgresql.org>
	<CAApHDvr7Ysn0u=8J7yZ+cSFJcKpH_b+MNGt6ZVyMyqr97ym2tg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20240919.090134.1961749747398456709.ishii%40postgresql.org>
Precedence: bulk

> On Thu, 19 Sept 2024 at 00:13, Tatsuo Ishii <ishii@postgresql.org> wrote:
>> Actually there's one more executor node type that uses tuplestore:
>> recursive union (used in "with recursive"). The particular node type
>> uses two tuplestore and we cannot simply apply tuplestore_get_stats()
>> to the node type. We need to modify RecursiveUnionState to track the
>> maximum tuplestore usage. I am not sure this would be worth the
>> effort. Opinion?
> 
> Could you add the two sizes together and take the storage type from
> the tuplestore with the highest storage size?

I don't think this works because tuplestore_begin/tuplestore_end are
called while executing the node (ExecRecursiveUnion).

I think the way you are proposing only shows the stats last time when
those tuplestore are created.

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp