Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1srC8K-00G1jd-4s for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Sep 2024 08:03:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1srC8I-006MfY-1c for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Sep 2024 08:03:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1srC8H-006MfQ-LM for pgsql-hackers@lists.postgresql.org; Thu, 19 Sep 2024 08:03:21 +0000 Received: from fout7-smtp.messagingengine.com ([103.168.172.150]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1srC8B-001wBm-5J for pgsql-hackers@lists.postgresql.org; Thu, 19 Sep 2024 08:03:20 +0000 Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id 740D813802CF; Thu, 19 Sep 2024 04:03:12 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Thu, 19 Sep 2024 04:03:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1726732992; x= 1726819392; bh=TzbibDnDKpZX2nc+gIfmCaQrVAcyxXqw4HY8F0iTZhs=; b=F 6eyGptyVckVYqocEu3wZ5F8o+1BIvbmx5sVx1qP19ZbA5T+l3aIHW7IaVPDo4bnK MDpxLaSXbbVWqTXTpMA8YP12Veh5ZB3K2ebFvxOEqMMtTBVTFlWQ7pjA7d/kN106 Ei/vkb7nt2djJd418PvsE3I8lDb6UC6Qqg1b+WpfvuhLZyuDMTn4cZReDYQ8i5UK t4Ue3oeockUDmSW3cKPdM/Ziqhw+HL+CUCkHZ2WuLppCDhpiogD0mjoIJ3YzPm66 2GhBjPJMwVxB/ZVuFoR0Q5rDCH1FxUn2rZIU6AcjZ6iFixu/Kf4JnYYgpGiPiTGw DdSuFYgeuR3AtfXIngfCg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeltddgudeftdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfggtggugfgjsehmkeerredttdej necuhfhrohhmpeetlhhvrghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvh hhrdhnohdqihhprdhorhhgqeenucggtffrrghtthgvrhhnpeduleekkefgtddttedtkefg uddvieffleetgeejiefhteehkeevfeettdduvdfhueenucffohhmrghinhepvghnthgvrh hprhhishgvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomheprghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrghdpnhgspg hrtghpthhtohepgedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepuggrvhhiugdr ghdrjhhohhhnshhtohhnsehgmhgrihhlrdgtohhmpdhrtghpthhtohepnhgrthhhrghnug gsohhsshgrrhhtsehgmhgrihhlrdgtohhmpdhrtghpthhtohepphhgshhqlhdqhhgrtghk vghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhgpdhrtghpthhtohepmhhitg hhrggvlhesphgrqhhuihgvrhdrgiihii X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Sep 2024 04:03:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alvh.no-ip.org; s=schmee; t=1726732989; bh=BBg2CQfkifpnodxynXnOdEB0uxUVZSpjl/1+JxmuskE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=HuKmAm//xa+a3BJMDHvlvkGArmyGr7H24oOI784vEO+ZyNTg02kjYy2L7a7FydAQy 5IC8rLaTWDWujD2fiY18hH+y5mNWXX3ta5XGxBBTQ9cLfo+FvA64MU3oxFmq9VfstL BPEm2XuBAkzlz1qmwi8dHdYVS9nhEeN9DH4gTI9/PTOhovqZBR1LgIdJmFcYa6EtKA +0qCpnQXmjEFhNqooi7Sq9+kZUqL0zJQ6QjO8a81Q2GZnNUw57C1jRB6TA/GoYop5o PAavHiNIy0e391O6ea0/B7UtvRRS8WciWBVJfToH+QMP05a1Q9zyfFwVaC6vMQwhxW UZUj3OXmpfrsg== Received: by schmee.alvh.no-ip.org (Postfix, from userid 1000) id 24A34B9; Thu, 19 Sep 2024 10:03:09 +0200 (CEST) Date: Thu, 19 Sep 2024 10:03:09 +0200 From: Alvaro Herrera To: Michael Paquier Cc: Nathan Bossart , "David G. Johnston" , Postgres hackers Subject: Re: Partitioned tables and [un]loggedness Message-ID: <202409190803.tnis52adt2n5@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="gypx7yxlz4hyntnq" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --gypx7yxlz4hyntnq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On 2024-Sep-10, Michael Paquier wrote: > @@ -5060,17 +5061,17 @@ ATPrepCmd(List **wqueue, Relation rel, AlterTableCmd *cmd, > pass = AT_PASS_MISC; > break; > case AT_AttachPartition: > - ATSimplePermissions(cmd->subtype, rel, ATT_TABLE | ATT_PARTITIONED_INDEX); > + ATSimplePermissions(cmd->subtype, rel, ATT_TABLE | ATT_PARTITIONED_TABLE | ATT_PARTITIONED_INDEX); > /* No command-specific prep needed */ > pass = AT_PASS_MISC; > break; > case AT_DetachPartition: > - ATSimplePermissions(cmd->subtype, rel, ATT_TABLE); > + ATSimplePermissions(cmd->subtype, rel, ATT_TABLE | ATT_PARTITIONED_TABLE); > /* No command-specific prep needed */ > pass = AT_PASS_MISC; > break; > case AT_DetachPartitionFinalize: > - ATSimplePermissions(cmd->subtype, rel, ATT_TABLE); > + ATSimplePermissions(cmd->subtype, rel, ATT_TABLE | ATT_PARTITIONED_TABLE); > /* No command-specific prep needed */ > pass = AT_PASS_MISC; > break; It looks to me like these cases could be modified to accept only ATT_PARTITIONED_TABLE, not ATT_TABLE anymore. The ATT_TABLE cases are useless anyway, because they're rejected by transformPartitionCmd. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ --gypx7yxlz4hyntnq Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="0001-Don-t-take-ATT_TABLE-for-ALTER-TABLE-.-ATTACH-DETACH.patch" From eab048c9c7e01df46b0d98d68507c98d9fa187c1 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Thu, 19 Sep 2024 09:51:07 +0200 Subject: [PATCH] Don't take ATT_TABLE for ALTER TABLE ... ATTACH/DETACH --- src/backend/commands/tablecmds.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 2d703aa22e..d27e6cf345 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -5107,19 +5107,17 @@ ATPrepCmd(List **wqueue, Relation rel, AlterTableCmd *cmd, break; case AT_AttachPartition: ATSimplePermissions(cmd->subtype, rel, - ATT_TABLE | ATT_PARTITIONED_TABLE | ATT_PARTITIONED_INDEX); + ATT_PARTITIONED_TABLE | ATT_PARTITIONED_INDEX); /* No command-specific prep needed */ pass = AT_PASS_MISC; break; case AT_DetachPartition: - ATSimplePermissions(cmd->subtype, rel, - ATT_TABLE | ATT_PARTITIONED_TABLE); + ATSimplePermissions(cmd->subtype, rel, ATT_PARTITIONED_TABLE); /* No command-specific prep needed */ pass = AT_PASS_MISC; break; case AT_DetachPartitionFinalize: - ATSimplePermissions(cmd->subtype, rel, - ATT_TABLE | ATT_PARTITIONED_TABLE); + ATSimplePermissions(cmd->subtype, rel, ATT_PARTITIONED_TABLE); /* No command-specific prep needed */ pass = AT_PASS_MISC; break; -- 2.39.2 --gypx7yxlz4hyntnq--