Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ssdtk-009mix-MK
	for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Sep 2024 07:54:21 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ssdtj-003ppc-TN
	for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Sep 2024 07:54:19 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ishii@postgresql.org>)
	id 1ssdtj-003ppT-8A
	for pgsql-hackers@lists.postgresql.org; Mon, 23 Sep 2024 07:54:19 +0000
Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ishii@postgresql.org>)
	id 1ssdtg-000dKs-7K
	for pgsql-hackers@postgresql.org; Mon, 23 Sep 2024 07:54:18 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=postgresql.org; s=20171124; h=Content-Transfer-Encoding:Content-Type:
	Mime-Version:References:In-Reply-To:From:Subject:Cc:To:Message-Id:Date:Sender
	:Reply-To:Content-ID:Content-Description;
	bh=HMfNzDhxiu8INqzf0UQmziGZ0ExOQeOmJ9A0FhUWmLA=; b=m9yiJW19bpPn0hZIpSiKFPrc5X
	ybGg0L0ldX4GhB1g7w42OZV28xyR+HmQA9UhsJRJeRbmhxtApJPQDgYqKJVePToFmVewyJS6kzW43
	NyaMPH0xb3rg43YvRiV1U0PhncrxZVZT+cbXEQDxu1iOqV+zubBYPX+1ZZuTK7FU+F6RUTSIrEzRb
	ycVeFqx7qQw+2YnlkJ1CvVqUisqEkdDV2J8HdcT4W7DGqyKGWj13e6Ollmo2TAw06sE8QggQv232N
	lB9Tj8eJXLTHuZzevxrnbkgVtjRus7eCAeBXoj6OpTLQVBovt2SGGh2DDpgYjZAd6U2+J6E0AoNbA
	gIN8FKug==;
Received: from [2409:11:4120:300:db3f:eef0:2f3:ae95] (helo=localhost)
	by meldrar.postgresql.org with esmtpsa  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256
	(Exim 4.94.2)
	(envelope-from <ishii@postgresql.org>)
	id 1ssdtd-001gTG-CA; Mon, 23 Sep 2024 07:54:17 +0000
Date: Mon, 23 Sep 2024 16:52:39 +0900 (JST)
Message-Id: <20240923.165239.993934717649779296.ishii@postgresql.org>
To: dgrowleyml@gmail.com
Cc: ashutosh.bapat.oss@gmail.com, orlovmg@gmail.com,
 jian.universality@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: 
 <CAApHDvo4xzas23uRDkMvjbKxjpsSK7a4QqSA_LPgYc7X7VdFaw@mail.gmail.com>
References: 
 <CAApHDvrqhYK8y+aR5KQ637szd5O47aiyQJmxBkw-nP4LaEU+xQ@mail.gmail.com>
	<20240923.152832.587968014191090400.ishii@postgresql.org>
	<CAApHDvo4xzas23uRDkMvjbKxjpsSK7a4QqSA_LPgYc7X7VdFaw@mail.gmail.com>
X-Mailer: Mew version 6.8 on Emacs 26.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Host-Lookup-Failed: Reverse DNS lookup failed for
 2409:11:4120:300:db3f:eef0:2f3:ae95 (failed)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20240923.165239.993934717649779296.ishii%40postgresql.org>
Precedence: bulk

> On Mon, 23 Sept 2024 at 18:28, Tatsuo Ishii <ishii@postgresql.org> wrote:
>> I agree and made necessary changes. See attached v4 patches.
> 
> Looks good to me.

Thank you for the review! I have pushed the patch.

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp