Date: Mon, 30 Sep 2024 14:20:21 +0900
From: Yugo NAGATA <nagata@sraoss.co.jp>
To: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: First draft of PG 17 release notes
Message-Id: <20240930142021.3776c6ebe5a35849719084fd@sraoss.co.jp>
In-Reply-To: <ZvirD5wt70As4hI_@momjian.us>
References: <ZjxLJpnH4VMkOMmi@momjian.us>
	<20240926141921.57d0b430fa53ac4389344847@sraoss.co.jp>
	<ZvirD5wt70As4hI_@momjian.us>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?q8GkU+rrtO/u2zJsUgBgdaJx0iXH95ki6V+pjKx97S+a9HeiUMOiPDweV3ak?=
 =?us-ascii?Q?0gCW7rkqptfwEkeyr1RgZDVTTsbuiB380mxVl/MeyDYTvGrvvpQBX2XvPPEP?=
 =?us-ascii?Q?uQub3jB7PrF/T43THk45OfZYNLdH2iVyhZSp9GmllfN9XfLWAjZ1Q/NVJk21?=
 =?us-ascii?Q?qB2NhldGyvOZ8PfgSgsa/KuN6nm8vv9WGTqqC0G5/oTaOkCycCcnFU3cQCK7?=
 =?us-ascii?Q?lxAu7P5fqtLrAjhLtsXOYuYsfYntuH7DuOGoP8RmuCMOOa0qKWgmQHw/5nxw?=
 =?us-ascii?Q?CjzQWivHIDICyOzFAMeSIo3+3KCs3SDaIo+azsFEGiCUOatCnSlMBQvVVVhW?=
 =?us-ascii?Q?9ulTNaS4H+eo7ztRiEuPGeze7vCWLSwKQOwbn6dzylEUpF6Gn8+AlTAntQ8O?=
 =?us-ascii?Q?vquFM4r8489DPbFEaWnowdjBdpGL4bqliGmu0CTdDU/js8sHR/j4+vTuH3hA?=
 =?us-ascii?Q?pWZ3UQ4rEU0zUPENFGgSx9fOY7VsCpH3Hio3my0in8MCH0yo1t7frHbxulr2?=
 =?us-ascii?Q?h2hMnbIgnDmMOr5r5Rjls9fbx6oz9EqCpefjYpnEae0otLuoEe2vSNJl8QaL?=
 =?us-ascii?Q?ClWxGNNNHm7Ld05FjcEgKTA1iGHTPQ/g//6EFqUKL3zPYOOMVcutalyJg/Yi?=
 =?us-ascii?Q?BEvh3asMpd2hcmB8b/XPS06enK4rUqdQJV9tOQfdBuYv2v7GGAacT8E8wehY?=
 =?us-ascii?Q?Ebiums7NEABvdJWb/8E+EHQWmuUSL91EfZ0h6PiimBkWee/ehGD5kMfTICxo?=
 =?us-ascii?Q?DqSAqbnl1rutWsLICpJufIrriRNjw7B2eY9W/OdKeAddcedoAh3sVoigZou2?=
 =?us-ascii?Q?EXvX09eYIO99+XunnxMfoMu7t7j4sh13Ybpaeag/tNSoW553mhb2Rjusb+7g?=
 =?us-ascii?Q?gfm4V5iZoAP9asaDQa5c/F6XNWs0pg6KDBMPT+y4gY0utkahkuXqmP5L8SZs?=
 =?us-ascii?Q?HkUD3r6f+ELD3RA3ajVccGd/eBXwqxo/B5skmRQnZnzh7rszndnKMGl4CbmK?=
 =?us-ascii?Q?PFDW7YkjlkFVUpZluhRNlTPgbapnWTSpO1iK+0evKk7gu7d5q0MGnF8Ht4/p?=
 =?us-ascii?Q?hoABv92w2ZsnbgXzltYHLBF7cEBzkg9+DolO+dE5AkVUnYF7jgLec9R9xaKh?=
 =?us-ascii?Q?Bhp6wRenS8NWVowiQ7C3y+lb9lq5pLM9ajxyX/rV3IyamqnDnV+ZuTiiPW2v?=
 =?us-ascii?Q?siQfpODQiYBfxlIfcjybt/PKZMh9l2euchGNGe0NTJftGebVYst61TcYRZ5w?=
 =?us-ascii?Q?e5H+TM8EEZ2ARZi+a7+gQmo3wZnS7m89Wlo+B8I4+jmAAijnTh8tki0xd6JT?=
 =?us-ascii?Q?BP5OuLn/7qUopN1X0fAsqL2nzliIQtugFou9AxOqc3YMhqFQpsnGYGBSvkpj?=
 =?us-ascii?Q?7AVL73v5E4LNf87dXO4X6skgsiCZSl+uU/NFAj8Y4nJl1vNw63OA81EZxpdt?=
 =?us-ascii?Q?EVHFiprOeY+Wzmg0H7PMeMtPES66fCCPmuTqSmwr9wbu5lLKZ8susoTf3zU6?=
 =?us-ascii?Q?0wwfuHkWXXB/v8jDK1AZDXgZTsW1XjF/j35EwXdZVCzYTO3hj9pRFLlsM02D?=
 =?us-ascii?Q?mD9SWS02fBOLg4fnHHzAGo4i8fM9VL+kKiwHZMYfqGTiLlBUwjyFfCwcdlL6?=
 =?us-ascii?Q?VCeykA0ivyUUjTDmdCq1/ZiFbXvLZKjkomTJuKhWcLf1?=
X-OriginatorOrg: sraoss.co.jp
X-MS-Exchange-CrossTenant-Network-Message-Id: bb517a0e-76ad-408c-5546-08dce10fa4e2
X-MS-Exchange-CrossTenant-AuthSource: TYBP286MB0111.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2024 05:20:48.9016
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 75db6c32-352e-4063-ae79-cafb8623f6db
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1Zkbzar8hTQWFBpnGo15QT/evISzFHj4WLjyxaZHfdtCRBKUPuvdx/OY4ngKDv7mQjpT5mYABuPVJiXxvGb6Lw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3P286MB2626
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/20240930142021.3776c6ebe5a35849719084fd%40sraoss.co.jp>
Precedence: bulk

On Sat, 28 Sep 2024 21:19:11 -0400
Bruce Momjian <bruce@momjian.us> wrote:

> On Thu, Sep 26, 2024 at 02:19:21PM +0900, Yugo Nagata wrote:
> > On Thu, 9 May 2024 00:03:50 -0400
> > Bruce Momjian <bruce@momjian.us> wrote:
> > 
> > > I have committed the first draft of the PG 17 release notes;  you can
> > > see the results here:
> > 
> > I propose to improve the following description in "Migration to Version 17"
> > section by adding CREATE INDEX and CREATE MATERIALIZED VIEW into the command list.
> > 
> >      <para>
> >      Change functions to use a safe <xref linkend="guc-search-path"/>
> >      during maintenance operations (Jeff Davis)
> >      <ulink url="&commit_baseurl;2af07e2f7">&sect;</ulink>
> >      </para>
> > 
> > It is suggested in the thread [1] that users could not notice the behaviour
> > of CREATE INDEX is changed because the explicit command name is not listed in
> > the release notes. So, I think it is better to add CREATE INDEX and
> > CREATE MATERIALIZED VIEW into the command list. 
> > 
> > I've attached a patch.
> 
> It this a valid change?  Seems so.

Yes. This change on CREATE INDEX was introduced by 2af07e2f7 together with
other commands, but it was missed to be mentioned in the commit message
although the description was added to the documentation.

The change on CEATE MATERIALIZED VIEW was introduced by a separate commit
b4da732fd, since which the REFRESH logic is used when creating a matview.
Should we add here a link to that commit, too?

Regards,
Yugo Nagata

> -- 
>   Bruce Momjian  <bruce@momjian.us>        https://momjian.us
>   EDB                                      https://enterprisedb.com
> 
>   When a patient asks the doctor, "Am I going to die?", he means 
>   "Am I going to die soon?"


-- 
Yugo NAGATA <nagata@sraoss.co.jp>