Date: Tue, 01 Oct 2024 12:02:27 +0900 (JST)
Message-Id: <20241001.120227.229328146975369640.ishii@postgresql.org>
To: nagata@sraoss.co.jp
Cc: pgsql-hackers@postgresql.org
Subject: Re: Doc: typo in config.sgml
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: <20240930180330.a8095414f7fa4e32d9f16985@sraoss.co.jp>
References: <20240930164728.ef465fb9fb15f505b47be31a@sraoss.co.jp>
	<20240930.172324.899716601478348332.ishii@postgresql.org>
	<20240930180330.a8095414f7fa4e32d9f16985@sraoss.co.jp>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20241001.120227.229328146975369640.ishii%40postgresql.org>
Precedence: bulk

> On Mon, 30 Sep 2024 17:23:24 +0900 (JST)
> Tatsuo Ishii <ishii@postgresql.org> wrote:
> 
>> >> I think there's an unnecessary underscore in config.sgml.
>> >> Attached patch fixes it.
>> > 
>> > I could not apply the patch with an error.
>> > 
>> >  error: patch failed: doc/src/sgml/config.sgml:9380
>> >  error: doc/src/sgml/config.sgml: patch does not apply
>> 
>> Strange. I have no problem applying the patch here.
>> 
>> > I found your patch contains an odd character (ASCII Code 240?)
>> > by performing `od -c` command on the file. See the attached file.
>> 
>> Yes, 240 in octal (== 0xc2) is in the patch but it's because current
>> config.sgml includes the character. You can check it by looking at
>> line 9383 of config.sgml.
> 
> Yes, you are right, I can find the 0xc2 char in config.sgml using od -c,
> although I still could not apply the patch. 
> 
> I think this is non-breaking space of (C2A0) of utf-8. I guess my
> terminal normally regards this as a space, so applying patch fails.
> 
> I found it also in line 85 of ref/drop_extension.sgml.

Thanks. I have pushed the fix for ref/drop_extension.sgml along with
config.sgml.

Best reagards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp