Feedback-ID: ia2694551:Fastmail
Date: Thu, 10 Oct 2024 18:38:36 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: jian he <jian.universality@gmail.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: overflow bug for inhcounts
Message-ID: <202410101638.qikdezkpvups@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CACJufxGrBzKBrkPjQr1zSYbQ4Z-jJz-OUA36-_ZPTZhMKo+CFw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202410101638.qikdezkpvups%40alvherre.pgsql>
Precedence: bulk

On 2024-Oct-09, jian he wrote:

> CreateConstraintEntry(const char *constraintName,

> we can change
> int conInhCount,
> to
> int16 conInhCount.
> doing that, meaning we also need to refactor some of the caller functions.

Good thought, thanks.

> we can also change
> node Constraint field inhcount from int to int16.

Nah, that field is unused, so I removed it.  I gave another look at the
not-nulls branch, and we can do without it.

This is pushed, although there was a technical glitch (since fixed by
Magnus Hagander) and the pgsql-committers message was not sent.  But you
can see it here:

https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=fd64ed60b62697984bb69a09a3ae19fbe2905eb6

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/