Date: Fri, 11 Oct 2024 12:27:13 +0900
From: Yugo Nagata <nagata@sraoss.co.jp>
To: px shi <spxlyy123@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Remove unlogged materialized view persistence handling
Message-Id: <20241011122713.ae6b9fa0b4574c65d8bd08d7@sraoss.co.jp>
In-Reply-To: <CAAccyYKRZ=OvAvgowiSH+OELbStLP=p2Ht=R3CgT=OaNSH5DAA@mail.gmail.com>
References: <CAAccyYKRZ=OvAvgowiSH+OELbStLP=p2Ht=R3CgT=OaNSH5DAA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?iso-2022-jp?B?T3gveWMzbDNpcXY1TnlGcGxNL0IxK1dmTnkyRmRUak45Tm1CeVlpbzZU?=
 =?iso-2022-jp?B?OHJDdzk0NkxuZmhoRE9GNDZKUFYyYVJvQ3RHQmYraTBJUUt3Z3QvL1hZ?=
 =?iso-2022-jp?B?TzdOZ2xST0pkZGpQU25IQncyQllDSldTam0vMVdwNS93RVYxMENlSXV6?=
 =?iso-2022-jp?B?TURNQ09VRStteU4xUkRvdEZCK3FFbER0NWRYbm01VFN5UUovMDRSMklO?=
 =?iso-2022-jp?B?Mmw2SDZNMWpYOXhXTytDVUxhU0p4THZ2d09EZllQSXQxUW9odms4MU5Z?=
 =?iso-2022-jp?B?Q2E3eHpuYVBJMU5MWWVKNXBwVVR2OS83dUZFZlFSeDZjSHBuTjgvckFR?=
 =?iso-2022-jp?B?QjdsOXlsNjExb0tRNlNqQm1OQVNhMzBRVWhUMWZka2lReU81Z0YxdzNy?=
 =?iso-2022-jp?B?cGFMTkExMXp3QndRN0NkTFAyTkZtTDM5S3VudFAvdVpYZkN0Y0lCSHpn?=
 =?iso-2022-jp?B?QWVPRjU3ZElvQkk5UWJiUW9hcWtadzBraExxaWlpMVNQUDV4dUtFeXdk?=
 =?iso-2022-jp?B?d2JnbjhuRXhTREphb3VwVkIxeUdXOUx0aWpxNS93VzJkcWxSUno2aEZN?=
 =?iso-2022-jp?B?bEYveTlLckF6TlhTbXhkUE1oNU9MNlNQWlJsY25mekVMZEY3VDVnK1JS?=
 =?iso-2022-jp?B?MWZKUmpPRkE5bHZSY1NvTVE0b05Hbm14Zlhyc05qWFhaM3YwOS9HRDJB?=
 =?iso-2022-jp?B?WXNNZXhDZFNrbXFHQjlwUU85SVFqT3FOSFVHQjFsN256eG5kREhHYlh6?=
 =?iso-2022-jp?B?OUpxb1F0N0NBRkN3QlpDS084SkQxQzlqbitVU09DSWxkTzExNHdvQmNs?=
 =?iso-2022-jp?B?QVhFMTRhTm12K0lXY213RXBsRjNmVmI4bFdRNTh1SVVZS1RocE0yTFVq?=
 =?iso-2022-jp?B?SmFoMGRZd0NQNTN1RUFidVFCcE1OT3NOa2MrdGk3VExENFJpeDFRTm9X?=
 =?iso-2022-jp?B?V3ZyckduRU8vWmpJRlFJZVM5dEpVNnlXSFNvVHBqSWtrZmRFRFBrYVJC?=
 =?iso-2022-jp?B?MHhaN0daR2hFaEV1bGpXVldBNVBTYlo2Umh6b29kZkxoTExhL2M3UGNQ?=
 =?iso-2022-jp?B?Rnd3TUhzd3R3d2Vxa0NXbklwZUZ0TnJEY0dsQVZHTkQydlZTcENOQm05?=
 =?iso-2022-jp?B?UkluV1dXcmt5ZFJqVzJydFFYY3liT1lYbE4rc0tqOW1ET3ROakt1S08v?=
 =?iso-2022-jp?B?dUtuUStpYVk3YzBTMXlUN0ZwM1p4ZHRDR2FPa0tSM3pCamo1QXJ4U1NC?=
 =?iso-2022-jp?B?a1YrQ2FHVVJadGwydE5kSWJ4NXB3V0svdHZEQmRFTFR2RE5YckVKSmk5?=
 =?iso-2022-jp?B?WDVqaUZ0Q01UUkRxY25GT2c4eVpoNGVZRUtXZ25BM0NDVjYrVjhNSGxn?=
 =?iso-2022-jp?B?SXFkV3BHRlVnNG9selo5Q0NUTEk2VFY0ZGFFU21rTE9qYTZ6N2JzeHYy?=
 =?iso-2022-jp?B?MlBKL1dLTWxERnNES2hub0NqdkpZUmMwMnFQYXozaDlYbzl1NzBWNzdN?=
 =?iso-2022-jp?B?NWJiWFUxSHRKWStncEFQeGtLSVNQT0VJdXQrY0lTZzBOdWtXb2dQWlhW?=
 =?iso-2022-jp?B?T2lXK05MSXdJRm9nMEU0M0xyNjlBbTN2cnVIbE1jd21LZW1qSmNpTFpw?=
 =?iso-2022-jp?B?R2MyczB3SGJUQ29CZURIQXdRT2NPRzI5dEZFL05Bc0grRWkrdUdHQnlW?=
 =?iso-2022-jp?B?dC9BaGVGWVJydnBkaE44c1A3dUtJL3lpdXQzUjJ0eVBhOGpoM0plNnR2?=
 =?iso-2022-jp?B?YjZkZjljZFpkRHlHNmZUMEVuZ3lycmRkcTJpRW9CcTBPeWJMVlY1MFBI?=
 =?iso-2022-jp?B?Ync5ZHgyTmNYOEFZU0VpejMxRGVtcXZwWGlwcXpSMFB1MGN4OHpGWUJh?=
 =?iso-2022-jp?B?QVF0U2hEc3Zja0pOMFdhZDVMZ3V3UVBhZ2lmOGx6UGc0b2JLS1gzb3lU?=
 =?iso-2022-jp?B?NzF0LzE1eU02TE9vQWlCODVqMjZ0V2JKNXFYQmdia2M5SGZ5VG5oVFht?=
 =?iso-2022-jp?B?LzVSTkFlQnN4ZFUzU29GY2N0alVGNmE4Tm1xYzY3TkNpYitGM1hGdExT?=
 =?iso-2022-jp?B?MVdiNzljTkNHN3FUMk51TTcwMjd6WFVzSjk1U0loak9hSGhvMGJoeFhE?=
 =?iso-2022-jp?B?b0ovTE9XS3FmVGlnelRIT1pqMUJ6Zy8ra0dEYVdXQnpyY29PUG0yMEVi?=
 =?iso-2022-jp?B?eUorY2hoay9DVU1wVlpPdkxiNGo2WXdlSXJQdDhMTzhCNHExMVU4SjNk?=
 =?iso-2022-jp?B?RFE4Z281KzMrRm9nU2k3VjdTa3lWU3Q3QWlpUW9uNzRBMTJTbGpHODh3?=
 =?iso-2022-jp?B?R1pVaVJmZjE5TmRsZytrM2RPU01lem5qNll4SkdxNnJyZmZ2LzRLd202?=
 =?iso-2022-jp?B?bkF4SUkvbkZVQzBtckJESjFFUnYzN2w4c1c=?=
X-OriginatorOrg: sraoss.co.jp
X-MS-Exchange-CrossTenant-Network-Message-Id: 88c1d529-bc64-4cd3-54d6-08dce9a49933
X-MS-Exchange-CrossTenant-AuthSource: TYBP286MB0111.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2024 03:27:13.5443
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 75db6c32-352e-4063-ae79-cafb8623f6db
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GgG4oofaCDgaorSPGky8p2AyrzUuqFO9KN8e9hgYkr4O+o/MKs+/q7uhUdbfI2vUCDKi3rwyMkOHyN3PsSK0YA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYRP286MB4813
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/20241011122713.ae6b9fa0b4574c65d8bd08d7%40sraoss.co.jp>
Precedence: bulk

On Fri, 11 Oct 2024 10:35:17 +0800
px shi <spxlyy123@gmail.com> wrote:

> Hi，
> 
> Since materialized views do not support the unlogged type, I think that we
> should remove the logic and handling related to unlogged. Therefore, I have
> submitted a patch.

+1

Materialized view is introduced by 3bf3ab8c563 and at that UNLOGGED was
allowed, and it is disallowed by another commit 3223b25ff73. However,
it seems that the tab-complement is missed to fixed.

The Assert for RELKIND_MATVIEW in heapam_hander.c was introduced in d25f519107b
after that, but I think it can be also removed.

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>