Feedback-ID: ia2694551:Fastmail
Date: Fri, 25 Oct 2024 10:30:33 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tender Wang <tndrwang@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>,
	Jehan-Guillaume de Rorthais <jgdr@dalibo.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Guillaume Lelarge <guillaume@lelarge.info>
Subject: Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails
Message-ID: <202410250830.puisbzuy4yyj@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAHewXN=Ut0ijPndwt+FJ1qs6buofz4wn6O4umUd0OcRgOPjORQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202410250830.puisbzuy4yyj%40alvherre.pgsql>
Precedence: bulk

On 2024-Oct-25, Tender Wang wrote:

> Thanks for reporting. I can reproduce this memory invalid access on HEAD.
> After debuging codes, I found the root cause.
>  In DetachPartitionFinalize(), below code:
> att = TupleDescAttr(RelationGetDescr(partRel),
>                                attmap->attnums[conkey[i] - 1] - 1);
> 
> We should use confkey[i] -1 not conkey[i] - 1;

Wow, how embarrasing, now that's one _really_ stupid bug and it's
totally my own.  Thanks for the analysis!  I'll get this patched soon.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/